Skip to content

chore: align config between YAML files and docs; add missing service sections#397

Merged
hectorvent merged 1 commit intofloci-io:mainfrom
hampsterx:chore/config-docs-canonicalization
Apr 13, 2026
Merged

chore: align config between YAML files and docs; add missing service sections#397
hectorvent merged 1 commit intofloci-io:mainfrom
hampsterx:chore/config-docs-canonicalization

Conversation

@hampsterx
Copy link
Copy Markdown
Contributor

Summary

  • Fix rds.proxy-base-port drift in test YAML (70007001 to match main YAML)
  • Add missing apigatewayv2 section to main YAML, test YAML, and docs
  • Add missing acm, opensearch proxy ports, appconfigdata value, and acm storage flush to test YAML
  • Add appconfig, appconfigdata, and full ecr config to docs reference
  • Clarify note about unlisted keys in docs

Review

Pre-reviewed by Codex and Gemini. Findings:

  • Codex: improved docs note wording (applied)
  • Gemini: trailing newline fix (applied), flagged pre-existing RDS code default drift (out of scope, Java source)
  • Both confirmed apigatewayv2/acm/opensearch/appconfig/ecr additions are consistent across files

Changes

 docs/configuration/application-yml.md | +22 -1
 src/main/resources/application.yml    | +2  -0
 src/test/resources/application.yml    | +15 -2

Intentional test YAML differences (not drift)

  • ecs.mock: true (test) vs false (main): CI doesn't need Docker for ECS tasks
  • ECR minimal config in test: unit tests don't spin up a Docker registry
  • storage.wal.compaction-interval-ms: 60000 (test) vs 30000 (main): slower compaction during tests

Test plan

  • mvn test -B passes (1885/1886, 1 pre-existing ElastiCache failure unrelated to config)
  • Verified service ordering matches across all three files
  • Verified storage flush service ordering matches main YAML
  • Diff reviewed for accuracy against main YAML as source of truth

…sections

Close drift gaps between main YAML, test YAML, and docs reference.
Test YAML: fix rds.proxy-base-port (7000→7001), add apigatewayv2/acm
sections, expand opensearch with proxy ports, fix appconfigdata missing
value, add acm storage flush. Main YAML: add apigatewayv2 section.
Docs: add apigatewayv2/appconfig/appconfigdata/ecr full config blocks,
clarify note about unlisted keys.
Copy link
Copy Markdown
Collaborator

@hectorvent hectorvent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hampsterx

@hectorvent hectorvent merged commit 702faf5 into floci-io:main Apr 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants