fix(s3): remove XML declaration from GetBucketLocation response#403
Merged
hectorvent merged 1 commit intofloci-io:mainfrom Apr 13, 2026
Merged
Conversation
hectorvent
approved these changes
Apr 13, 2026
Collaborator
|
Thanks @ctnnguyen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
GetBucketLocationresponse includes a<?xml version="1.0" encoding="UTF-8"?>declaration that AWS does not return. AWS SDK v2 uses a regex>(.+)<\/Locationto parse this response, and the?>in the XML declaration provides a>that the greedy.+matches from, causing the SDK to capture garbage instead of the actual region value. This breaks tools like Serverless Framework that rely on SDK v2's parsedLocationConstraintfor bucket region validation.Also uses a self-closing
<LocationConstraint ... />element for us-east-1 buckets to exactly match the AWS wire format.Type of change
fix:)feat:)feat!:orfix!:)AWS Compatibility
Incorrect behavior: Response included
<?xml version="1.0" encoding="UTF-8"?>prefix which AWS does not return for this API. This caused AWS SDK v2's regex-based parser to produce incorrectLocationConstraintvalues.Correct behavior (AWS): Response body is just the
<LocationConstraint>element with no XML declaration. For us-east-1, a self-closing<LocationConstraint xmlns="..."/>. For other regions,<LocationConstraint xmlns="...">region</LocationConstraint>.Checklist
./mvnw testpasses locally