fix: allow enum auto-mapping when source is a strict subset of target#28
Merged
fix: allow enum auto-mapping when source is a strict subset of target#28
Conversation
Replace set equality with toEntries.containsAll(fromEntries) in the FIR checker and enumsEqual. The IR side already emits Enum.valueOf(source.name), which resolves correctly whenever every source entry name exists in the target. Target-only entries remain unreachable by construction. Closes #27 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toEntries.containsAll(fromEntries)in bothKMapperFirMappingChecker(direct enum-to-enum early return) andKmapperFirLogic.enumsEqual(nested enum field check).Enum.valueOf(source.name)emission already handles subset mapping correctly at runtime.Test plan
EnumMappingTest.shouldCompile_sourceSubsetOfTargetcovers the issue's reproducer (Generation { GEN_Z, BOOMER }→GenerationDto { GEN_Z, MILLENNIALS, BOOMER }) and asserts the expected runtime output.shouldFail_notEqualEnums→shouldFail_sourceSupersetOfTargetand flipped the enums so the failing direction (source has entries the target lacks) still producesMissing mapping for: gender../gradlew :test-integration:testpasses end-to-end — no regressions in other enum / nested / label-property / collection scenarios.Closes #27
🤖 Generated with Claude Code