Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions src/extension/arrow-ext/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions src/extension/arrow-ext/php/Flow/Arrow/OutputStream.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

namespace Flow\Arrow;

if (\extension_loaded('arrow')) {
return;
}

interface OutputStream
{
public function append(string $data) : self;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

namespace Flow\Arrow\Parquet;

final class Exception extends \RuntimeException
if (\extension_loaded('arrow')) {
return;
}

final class Exception extends \Exception
{
}
4 changes: 4 additions & 0 deletions src/extension/arrow-ext/php/Flow/Arrow/RandomAccessFile.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

namespace Flow\Arrow;

if (\extension_loaded('arrow')) {
return;
}

interface RandomAccessFile
{
public function read(int $length, int $offset) : string;
Expand Down
17 changes: 17 additions & 0 deletions src/extension/arrow-ext/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,24 @@ pub extern "C" fn php_module_info(_module: *mut ModuleEntry) {
info_table_end!();
}

pub unsafe extern "C" fn module_startup(_type: i32, _module_number: i32) -> i32 {
if let Err(e) = stream::output_stream::register() {
eprintln!("arrow: failed to register Flow\\Arrow\\OutputStream: {e}");
return -1;
}
if let Err(e) = stream::random_access_file::register() {
eprintln!("arrow: failed to register Flow\\Arrow\\RandomAccessFile: {e}");
return -1;
}
if let Err(e) = parquet::exception::register() {
eprintln!("arrow: failed to register Flow\\Arrow\\Parquet\\Exception: {e}");
return -1;
}
0
}

#[php_module]
#[php(startup = "module_startup")]
pub fn get_module(module: ModuleBuilder) -> ModuleBuilder {
module
.info_function(php_module_info)
Expand Down
15 changes: 15 additions & 0 deletions src/extension/arrow-ext/src/parquet/exception.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
use ext_php_rs::builders::ClassBuilder;
use ext_php_rs::error::Result;
use ext_php_rs::exception::PhpException;
use ext_php_rs::flags::ClassFlags;
use ext_php_rs::zend::{ce, ClassEntry};

fn noop(_ce: &'static mut ClassEntry) {}

pub fn register() -> Result<()> {
ClassBuilder::new("Flow\\Arrow\\Parquet\\Exception")
.extends((ce::exception, "Exception"))
.flags(ClassFlags::Final)
.registration(noop)
.register()?;

Ok(())
}

fn parquet_exception_ce() -> &'static ClassEntry {
ClassEntry::try_find("Flow\\Arrow\\Parquet\\Exception")
.unwrap_or_else(|| ce::exception())
Expand Down
2 changes: 2 additions & 0 deletions src/extension/arrow-ext/src/stream/mod.rs
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
pub mod output_stream;
pub mod php_destination_stream;
pub mod php_source_stream;
pub mod random_access_file;
22 changes: 22 additions & 0 deletions src/extension/arrow-ext/src/stream/output_stream.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
use ext_php_rs::args::Arg;
use ext_php_rs::builders::{ClassBuilder, FunctionBuilder};
use ext_php_rs::error::Result;
use ext_php_rs::flags::{ClassFlags, DataType, MethodFlags};
use ext_php_rs::zend::ClassEntry;

fn noop(_ce: &'static mut ClassEntry) {}

pub fn register() -> Result<()> {
ClassBuilder::new("Flow\\Arrow\\OutputStream")
.flags(ClassFlags::Interface)
.registration(noop)
.method(
FunctionBuilder::new_abstract("append")
.arg(Arg::new("data", DataType::String))
.returns(DataType::Object(Some("self")), false, false),
MethodFlags::Public | MethodFlags::Abstract,
)
.register()?;

Ok(())
}
28 changes: 28 additions & 0 deletions src/extension/arrow-ext/src/stream/random_access_file.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
use ext_php_rs::args::Arg;
use ext_php_rs::builders::{ClassBuilder, FunctionBuilder};
use ext_php_rs::error::Result;
use ext_php_rs::flags::{ClassFlags, DataType, MethodFlags};
use ext_php_rs::zend::ClassEntry;

fn noop(_ce: &'static mut ClassEntry) {}

pub fn register() -> Result<()> {
ClassBuilder::new("Flow\\Arrow\\RandomAccessFile")
.flags(ClassFlags::Interface)
.registration(noop)
.method(
FunctionBuilder::new_abstract("read")
.arg(Arg::new("length", DataType::Long))
.arg(Arg::new("offset", DataType::Long))
.returns(DataType::String, false, false),
MethodFlags::Public | MethodFlags::Abstract,
)
.method(
FunctionBuilder::new_abstract("size")
.returns(DataType::Long, false, true),
MethodFlags::Public | MethodFlags::Abstract,
)
.register()?;

Ok(())
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
--TEST--
arrow extension registers OutputStream, RandomAccessFile interfaces and Parquet\Exception class
--SKIPIF--
<?php if (!extension_loaded("arrow")) die("skip arrow extension not loaded"); ?>
--FILE--
<?php
var_dump(interface_exists('Flow\Arrow\OutputStream', false));
var_dump(interface_exists('Flow\Arrow\RandomAccessFile', false));
var_dump(class_exists('Flow\Arrow\Parquet\Exception', false));
var_dump(is_subclass_of('Flow\Arrow\Parquet\Exception', \Exception::class));

$r = new ReflectionClass('Flow\Arrow\OutputStream');
var_dump($r->isInterface());
var_dump($r->hasMethod('append'));

$r = new ReflectionClass('Flow\Arrow\RandomAccessFile');
var_dump($r->isInterface());
var_dump($r->hasMethod('read'));
var_dump($r->hasMethod('size'));
?>
--EXPECT--
bool(true)
bool(true)
bool(true)
bool(true)
bool(true)
bool(true)
bool(true)
bool(true)
bool(true)
Loading