refactor: dont list remote storages when precise file path is used#2331
Merged
norberttech merged 1 commit into1.xfrom Apr 25, 2026
Merged
refactor: dont list remote storages when precise file path is used#2331norberttech merged 1 commit into1.xfrom
norberttech merged 1 commit into1.xfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2331 +/- ##
===========================================
+ Coverage 10.84% 84.29% +73.45%
===========================================
Files 1540 1540
Lines 58115 58157 +42
===========================================
+ Hits 6300 49022 +42722
+ Misses 51815 9135 -42680
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
This behavior was noticed in one of the projects I have been consulting.
What happens is that even when the extractor has a direct file path
s3://some-bucket/some-folder/file.xmlfor example the XMLParserExtrator is using list action on Streamsflow/src/adapter/etl-adapter-xml/src/Flow/ETL/Adapter/XML/XMLParserExtractor.php
Line 95 in 5ac37fe
And then in FilesystemStreams regardless is this is direct file path or folder or pattern we stilld call list.
flow/src/core/etl/src/Flow/ETL/Filesystem/FilesystemStreams.php
Lines 121 to 127 in 1558c15
This PR changes that behavior, now list methods of AzureBlob and AsyncAWSS3Filesystem will first (if that option is enabled) check if path is pointing to a file.
This way it wont need an actual list bucket / container permission