feat: add memory usage in PHPUnit telemetry data#2403
Merged
Conversation
jdecool
force-pushed
the
1.x-feat-memory-usage
branch
from
ffce563 to
ae3ee13
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2403 +/- ##
=========================================
Coverage 84.81% 84.82%
- Complexity 20456 20465 +9
=========================================
Files 1556 1557 +1
Lines 62813 62848 +35
=========================================
+ Hits 53273 53308 +35
Misses 9540 9540 🚀 New features to boost your workflow:
|
jdecool
force-pushed
the
1.x-feat-memory-usage
branch
from
ae3ee13 to
79269d5
Compare
norberttech
reviewed
May 30, 2026
| try { | ||
| if ($this->config->emitTestSpans || $this->config->emitMetrics) { | ||
| memory_reset_peak_usage(); | ||
| $this->memoryRegistry->setStart($event->test()->id(), memory_get_usage()); |
Member
There was a problem hiding this comment.
I wonder if we should not parametrize it and allow users to decide if they want to pass bool $real_usage argument.
jdecool
force-pushed
the
1.x-feat-memory-usage
branch
from
79269d5 to
8799c23
Compare
jdecool
commented
May 30, 2026
| <parameter name="emit_metrics" value="true"/> | ||
| <parameter name="emit_test_spans" value="true"/> | ||
| <parameter name="emit_test_case_spans" value="true"/> | ||
| <parameter name="memory_real_usage" value="false"/> |
Contributor
Author
There was a problem hiding this comment.
False because it's the default PHP behaviour
Contributor
Author
|
Thanks @norberttech |
Member
|
Thank you @jdecool 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security