Skip to content

Add PHPUnit bridge compatibility with PHPUnit 11/12/13#2406

Merged
norberttech merged 1 commit into
flow-php:1.xfrom
jdecool:phpunit-compatibility
May 31, 2026
Merged

Add PHPUnit bridge compatibility with PHPUnit 11/12/13#2406
norberttech merged 1 commit into
flow-php:1.xfrom
jdecool:phpunit-compatibility

Conversation

@jdecool
Copy link
Copy Markdown
Contributor

@jdecool jdecool commented May 31, 2026

Change Log


Added

  • Add PHPUnit bridge compatibility with PHPUnit 11/12/13

Fixed

Changed

Removed

Deprecated

Security

Description


The PHPUnit extension for OpenTelemetry is very interesting but it's actually only compatible with PHPUnit 11.

So this PR allows the bridge to be installed with versions 12 and 13.

I've updated the CI workflow to run tests for those dedicated versions.

@jdecool jdecool requested a review from norberttech as a code owner May 31, 2026 11:16
@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.83%. Comparing base (d3a74d0) to head (75a9dd9).
⚠️ Report is 2 commits behind head on 1.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##                1.x    #2406   +/-   ##
=========================================
  Coverage     84.83%   84.83%           
  Complexity    20539    20539           
=========================================
  Files          1559     1559           
  Lines         63036    63036           
=========================================
  Hits          53477    53477           
  Misses         9559     9559           
Components Coverage Δ
etl 89.35% <ø> (+<0.01%) ⬆️
cli 89.40% <ø> (ø)
lib-array-dot 81.44% <ø> (ø)
lib-azure-sdk 64.44% <ø> (ø)
lib-doctrine-dbal-bulk 93.61% <ø> (ø)
lib-filesystem 85.03% <ø> (ø)
lib-types 91.98% <ø> (ø)
lib-parquet 68.89% <ø> (ø)
lib-parquet-viewer 82.26% <ø> (ø)
lib-snappy 89.82% <ø> (-0.45%) ⬇️
lib-dremel 0.00% <ø> (ø)
lib-postgresql 88.39% <ø> (ø)
lib-telemetry 84.31% <ø> (ø)
bridge-filesystem-async-aws 92.74% <ø> (ø)
bridge-filesystem-azure 90.45% <ø> (ø)
bridge-monolog-http 97.86% <ø> (ø)
bridge-monolog-telemetry 94.11% <ø> (ø)
bridge-openapi-specification 92.07% <ø> (ø)
symfony-http-foundation 78.57% <ø> (ø)
bridge-psr18-telemetry 100.00% <ø> (ø)
bridge-psr3-telemetry 97.84% <ø> (ø)
bridge-psr7-telemetry 100.00% <ø> (ø)
bridge-telemetry-otlp 90.50% <ø> (ø)
bridge-symfony-http-foundation-telemetry 89.47% <ø> (ø)
bridge-symfony-filesystem-bundle 91.54% <ø> (ø)
bridge-symfony-filesystem-cache 98.14% <ø> (ø)
bridge-symfony-postgresql-bundle 94.53% <ø> (ø)
bridge-symfony-postgresql-cache 94.41% <ø> (ø)
bridge-symfony-postgresql-messenger 98.80% <ø> (ø)
bridge-symfony-postgresql-session 93.65% <ø> (ø)
bridge-symfony-telemetry-bundle 76.00% <ø> (ø)
adapter-chartjs 84.05% <ø> (ø)
adapter-csv 91.16% <ø> (ø)
adapter-doctrine 90.79% <ø> (ø)
adapter-elasticsearch 92.07% <ø> (ø)
adapter-google-sheet 99.18% <ø> (ø)
adapter-http 73.04% <ø> (ø)
adapter-json 88.63% <ø> (ø)
adapter-logger 50.00% <ø> (ø)
adapter-parquet 81.75% <ø> (ø)
adapter-text 74.13% <ø> (ø)
adapter-xml 83.40% <ø> (ø)
adapter-avro 0.00% <ø> (ø)
adapter-excel 94.21% <ø> (ø)
adapter-postgresql 90.44% <ø> (ø)
bridge-phpunit-postgresql 75.30% <ø> (ø)
bridge-phpunit-telemetry 80.09% <ø> (ø)
bridge-phpstan-types 0.00% <ø> (ø)
bridge-postgresql-valinor 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jdecool jdecool force-pushed the phpunit-compatibility branch from 830f301 to 9f6a397 Compare May 31, 2026 11:27
Comment thread Justfile Outdated
tools/phpunit/vendor/bin/phpunit {{args}}

# Run the PHPUnit bridge test suites (postgresql + telemetry).
test-telemetry *args:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to not add dedicated sub actions for tests, instead the GH workflow can use just test and pass required options (PHP unit telemetry bridge test suites)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ I've updated the PR.

@jdecool jdecool force-pushed the phpunit-compatibility branch from 9f6a397 to 75a9dd9 Compare May 31, 2026 11:54
MemoryUsage::fromBytes(0),
MemoryUsage::fromBytes(0),
new GarbageCollectorStatus(0, 0, 0, 0, null, null, null, null, null, null, null, null),
new GarbageCollectorStatus(0, 0, 0, 0, 0.0, 0.0, 0.0, 0.0, false, false, false, 0),
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: args 5-12 are nullable in 11 but typed & required in 12+.

@norberttech norberttech merged commit 79edb80 into flow-php:1.x May 31, 2026
38 checks passed
@norberttech
Copy link
Copy Markdown
Member

Thank you @jdecool, good work! 💪

@jdecool jdecool deleted the phpunit-compatibility branch May 31, 2026 12:28
@norberttech norberttech added this to the 0.39.0 milestone May 31, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in Roadmap May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants