Add PHPUnit bridge compatibility with PHPUnit 11/12/13#2406
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2406 +/- ##
=========================================
Coverage 84.83% 84.83%
Complexity 20539 20539
=========================================
Files 1559 1559
Lines 63036 63036
=========================================
Hits 53477 53477
Misses 9559 9559 🚀 New features to boost your workflow:
|
830f301 to
9f6a397
Compare
norberttech
reviewed
May 31, 2026
| tools/phpunit/vendor/bin/phpunit {{args}} | ||
|
|
||
| # Run the PHPUnit bridge test suites (postgresql + telemetry). | ||
| test-telemetry *args: |
Member
There was a problem hiding this comment.
I would like to not add dedicated sub actions for tests, instead the GH workflow can use just test and pass required options (PHP unit telemetry bridge test suites)
Contributor
Author
There was a problem hiding this comment.
✅ I've updated the PR.
9f6a397 to
75a9dd9
Compare
jdecool
commented
May 31, 2026
| MemoryUsage::fromBytes(0), | ||
| MemoryUsage::fromBytes(0), | ||
| new GarbageCollectorStatus(0, 0, 0, 0, null, null, null, null, null, null, null, null), | ||
| new GarbageCollectorStatus(0, 0, 0, 0, 0.0, 0.0, 0.0, 0.0, false, false, false, 0), |
Contributor
Author
There was a problem hiding this comment.
Note: args 5-12 are nullable in 11 but typed & required in 12+.
norberttech
approved these changes
May 31, 2026
Member
|
Thank you @jdecool, good work! 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description
The PHPUnit extension for OpenTelemetry is very interesting but it's actually only compatible with PHPUnit 11.
So this PR allows the bridge to be installed with versions 12 and 13.
I've updated the CI workflow to run tests for those dedicated versions.