feat(telemetry): standardize emitted metric names and add messenger metric#2495
Merged
Conversation
…etric - rename metrics to namespaced keys: flow.etl.rows.*, flow.cache.*, flow.filesystem.*, flow.phpunit.*, db.client.* - emit messaging metrics for consumed/sent messages and process duration - add messenger `metrics` and `metrics_duration_unit` config (s|ms) - remove messenger `link_to_worker` and the `flow.messenger.worker` span link - add histogram bucket boundaries to postgresql duration/row metrics - document new metrics and add upgrade notes
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2495 +/- ##
============================================
+ Coverage 85.73% 85.74% +0.01%
- Complexity 0 21706 +21706
============================================
Files 1640 1641 +1
Lines 66951 67002 +51
============================================
+ Hits 57402 57454 +52
+ Misses 9549 9548 -1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
flow-php/symfony-telemetry-bundle- messenger instrumentation emits messaging metrics (consumed/sent counters, process duration histogram) with configurable unit and on/off toggleFixed
flow-php/postgresql- operation duration histogram uses correct second-scale bucket boundariesChanged
flow-php/etl- emitted metric names standardized toflow.etl.*andflow.cache.*flow-php/filesystem- emitted metric names standardized toflow.filesystem.*flow-php/postgresql- metric names aligned to OTELdb.client.*semantic conventionsflow-php/symfony-telemetry-bundle- cache metric names changed toflow.cache.*flow-php/phpunit-telemetry-bridge- metric names folded underflow.phpunit.*flow-php/telemetry- docblock metric name examples updatedRemoved
Deprecated
Security