fix(flow-php/etl): SchemaValidationException no longer lists columns accepted by the validator and renders the nullable marker on expected types #2504
Merged
Conversation
…accepted by the validator and renders the nullable marker on expected types (#2496 - SchemaValidator::isValid() replaced by validate() returning ValidationContext with missing/mismatched/unexpected definitions - exception message rendered from validator findings via ValidationContext::toString(), FROM_NULL columns no longer reported - schema_validate() DSL returns ValidationContext instead of bool - upgrading.md entry for the SchemaValidator API break - allow brick/math ^0.18
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2504 +/- ##
============================================
- Coverage 85.91% 85.90% -0.01%
- Complexity 21866 21871 +5
============================================
Files 1650 1652 +2
Lines 67516 67527 +11
============================================
+ Hits 58003 58011 +8
- Misses 9513 9516 +3 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2496
Change Log
Added
brick/math 0.18flow-php/etl-ValidationContextandMismatchedDefinitionvalue objects with schema diff rendering viaValidationContext::toString()flow-php/etl-SchemaValidationException::context()accessorFixed
flow-php/etl-SchemaValidationExceptionmessage no longer lists FROM_NULL columns accepted by the validatorflow-php/etl-SchemaValidationExceptionmessage renders the nullable?marker on expected typesChanged
flow-php/etl-SchemaValidator::isValid()replaced byvalidate()returningValidationContextflow-php/etl-schema_validate()returnsValidationContextinstead ofboolflow-php/etl- allowedbrick/math^0.18Removed
Deprecated
Security