Conversation
Pull Request Test Coverage Report for Build 1616
💛 - Coveralls |
|
Don't merge; I just wanted to check that the tests will pass. Will be ready for merge tonight after additional tests are added. |
…into multiagent_pr_2
AboudyKreidieh
left a comment
There was a problem hiding this comment.
please name multiagent_stabilizing_the_ring.py -> lord_of_the_rings.py
flow/core/vehicles.py
Outdated
| if isinstance(veh_id, (list, np.ndarray)): | ||
| return [self.get_lane_followers_speed(vehID, error) | ||
| for vehID in veh_id] | ||
| return self.__vehicles.get(veh_id, {}).get("followers_speed", error) |
AboudyKreidieh
left a comment
There was a problem hiding this comment.
from a high level, when is base_env.py used and when is multiagent_env.py used?
AboudyKreidieh
left a comment
There was a problem hiding this comment.
LGTM! please fix the comments first, but then feel free to merge
|
I'll also add some descriptions of this to the documentation first |
|
@AboudyKreidieh we should have this discussion before I merge: |

Separate PR for the multi-agent upgrades. @AboudyKreidieh I felt for you.