Skip to content

added save movie option to visualizer rllib#283

Merged
eugenevinitsky merged 9 commits intomasterfrom
save_movie
Nov 30, 2018
Merged

added save movie option to visualizer rllib#283
eugenevinitsky merged 9 commits intomasterfrom
save_movie

Conversation

@eugenevinitsky
Copy link
Copy Markdown
Member

Adds flag save_render to visuallizer_rllib which enables you to save the render as a movie in the ~/flow_movies folder.
Changes naming scheme in PygletRenderer to be easier to parse.
Adds drgb option to visuallizer_rllib.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 28, 2018

Pull Request Test Coverage Report for Build 1739

  • 12 of 29 (41.38%) changed or added relevant lines in 3 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+4.9%) to 84.33%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flow/visualize/visualizer_rllib.py 9 26 34.62%
Files with Coverage Reduction New Missed Lines %
tests/fast_tests/test_scenario_base_class.py 2 99.27%
tests/fast_tests/test_environment_base_class.py 2 99.02%
flow/envs/bay_bridge/base.py 4 63.25%
Totals Coverage Status
Change from base Build 1639: 4.9%
Covered Lines: 6684
Relevant Lines: 7926

💛 - Coveralls

@eugenevinitsky eugenevinitsky mentioned this pull request Nov 28, 2018
Copy link
Copy Markdown
Member

@AboudyKreidieh AboudyKreidieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See comment in the redis PR though.

@eugenevinitsky eugenevinitsky merged commit 8540691 into master Nov 30, 2018
@eugenevinitsky eugenevinitsky deleted the save_movie branch November 30, 2018 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants