Skip to content

Minor visualizer_rllib.py bug#288

Merged
eugenevinitsky merged 1 commit intoflow-project:masterfrom
kjang96:visualizer_rllib_bug
Nov 29, 2018
Merged

Minor visualizer_rllib.py bug#288
eugenevinitsky merged 1 commit intoflow-project:masterfrom
kjang96:visualizer_rllib_bug

Conversation

@kjang96
Copy link
Copy Markdown
Member

@kjang96 kjang96 commented Nov 29, 2018

The visualizer relies on the variable agent for computing actions.

The agent variable was mistakenly overwritten in for loops in between rollouts. I changed the for loop agent variable to be agent_id to resolve this issue.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1705

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 84.529%

Files with Coverage Reduction New Missed Lines %
flow/envs/bay_bridge/base.py 2 64.96%
Totals Coverage Status
Change from base Build 1698: 0.0%
Covered Lines: 6682
Relevant Lines: 7905

💛 - Coveralls

Copy link
Copy Markdown
Member

@eugenevinitsky eugenevinitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@eugenevinitsky eugenevinitsky merged commit 37c0130 into flow-project:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants