Merged
Conversation
themichaelyan
commented
Oct 2, 2024
| "medium_width": 77, | ||
| "medium_height": 50, | ||
| "large_width": 154, | ||
| "large_height": 100, |
Contributor
Author
There was a problem hiding this comment.
All the payment method logos have the same width and height defined here, but many of them don't match the actual width and height of the logo. I guess the dimensions are not used anywhere so it's not a problem. But I still set the actual width and height of the logo here.
Let me know if I missed anything.
Contributor
There was a problem hiding this comment.
I have spoken to @RoryH on this and he found that the only place this is used internally re managedmarkets is testbench - it always takes the largest image and scales it to 50px wide.
If shopify are pulling these images the mismatch in image size actual vs configured likely does not matter to them - but i think it's correct to have them match and be consistent.
themichaelyan
requested review from
ColmMathewsGlobalE,
jlogeart and
pragatid29
ColmMathewsGlobalE
approved these changes
Oct 3, 2024
ColmMathewsGlobalE
approved these changes
Oct 3, 2024
pmlemos
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://flowio.atlassian.net/browse/PAY-4067