COR-3430 - replace Bulgaria currency to EUR#130
COR-3430 - replace Bulgaria currency to EUR#130konstantin-petrukhnov-ge merged 2 commits intomainfrom
Conversation
📝 WalkthroughWalkthroughBulgaria's currency is changed from BGN to EUR across country data files; region data adds Bulgaria to Europe and Europe (Eurozone) country lists and adds Bulgarian language to the Europe languages list. Minor EOF/formatting newline fixes were applied. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🔇 Additional comments (5)
Comment |
There was a problem hiding this comment.
Looking at this PR, we should also make changes in the final folder (specifically the countries.json and regions.json files)
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
data/final/regions.json (2)
1889-1912: Fix alphabetical ordering of Bulgarian language in Eurozone.The Bulgarian language code "bg" is inserted after "cs", but alphabetically "bg" should precede "cs". This breaks the alphabetical sorting of the languages array.
🔎 Proposed fix to correct the sort order
"languages": [ - "cs", "bg", + "cs", "de", "el",
1618-1640: Remove BGN from regional currency lists to match Bulgaria's individual currency entry.Bulgaria's country entry lists only EUR as its currency, but the aggregate regions (Europe, European Economic Area, and European Union) still include BGN. This creates an inconsistency in the data. Remove BGN from the currency arrays in these regional aggregates at lines 1621, 1728, 1814, and 5385 to align with Bulgaria's canonical currency entry.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
data/final/countries.jsondata/final/regions.json
🔇 Additional comments (5)
data/final/countries.json (2)
3259-3259: LGTM: Proper EOF formatting.The trailing newline ensures standard file formatting.
435-435: Revert Bulgaria's currency to BGN or defer this change.Bulgaria's official Euro adoption is scheduled for January 1, 2026, not December 2025. The EU formally approved the accession on July 8, 2025, with the effective date set for January 1, 2026. The current change to "EUR" is premature for the current system time (December 2025) and should either be reverted to "BGN" or this file should be updated only on or after January 1, 2026.
Likely an incorrect or invalid review comment.
data/final/regions.json (3)
878-893: LGTM: Bulgaria region currency updated consistently.The Bulgaria region entry correctly reflects the Euro currency, consistent with the change in
countries.json.
1866-1866: LGTM: Bulgaria correctly added to Eurozone countries.BGR is properly positioned in alphabetical order between BEL and CYP.
5713-5713: LGTM: Proper EOF formatting.The trailing newline ensures standard file formatting.
COR-3430 - replace Bulgaria currency to EUR
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.