Skip to content

COR-3430 - replace Bulgaria currency to EUR#130

Merged
konstantin-petrukhnov-ge merged 2 commits intomainfrom
COR-3430-BGN-to-EUR
Dec 30, 2025
Merged

COR-3430 - replace Bulgaria currency to EUR#130
konstantin-petrukhnov-ge merged 2 commits intomainfrom
COR-3430-BGN-to-EUR

Conversation

@konstantin-petrukhnov-ge
Copy link
Copy Markdown
Contributor

@konstantin-petrukhnov-ge konstantin-petrukhnov-ge commented Dec 30, 2025

COR-3430 - replace Bulgaria currency to EUR

Summary by CodeRabbit

  • Chores
    • Updated Bulgaria's currency from BGN to EUR across datasets.
    • Added Bulgaria to Europe and Eurozone country lists and included Bulgarian (bg) in languages.
    • Minor formatting cleanup (ensured trailing newline/EOF consistency).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 30, 2025

📝 Walkthrough

Walkthrough

Bulgaria's currency is changed from BGN to EUR across country data files; region data adds Bulgaria to Europe and Europe (Eurozone) country lists and adds Bulgarian language to the Europe languages list. Minor EOF/formatting newline fixes were applied.

Changes

Cohort / File(s) Summary
Cleansed countries
data/cleansed/countries.json
Bulgaria's currency changed from BGN to EUR.
Final countries
data/final/countries.json
Bulgaria's default_currency changed from BGN to EUR; trailing newline added.
Final regions
data/final/regions.json
Bulgaria's currencies entry updated to EUR; Bulgaria (BGR) added to Europe and Europe (Eurozone) country lists; language bg added to Europe languages; trailing newline/final bracket formatting fixed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating Bulgaria's currency from BGN to EUR across the affected files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b29a028 and 65cb0a0.

📒 Files selected for processing (2)
  • data/final/countries.json
  • data/final/regions.json
🔇 Additional comments (5)
data/final/countries.json (2)

3259-3259: LGTM: Proper EOF formatting.

The trailing newline ensures standard file formatting.


435-435: Revert Bulgaria's currency to BGN or defer this change.

Bulgaria's official Euro adoption is scheduled for January 1, 2026, not December 2025. The EU formally approved the accession on July 8, 2025, with the effective date set for January 1, 2026. The current change to "EUR" is premature for the current system time (December 2025) and should either be reverted to "BGN" or this file should be updated only on or after January 1, 2026.

Likely an incorrect or invalid review comment.

data/final/regions.json (3)

878-893: LGTM: Bulgaria region currency updated consistently.

The Bulgaria region entry correctly reflects the Euro currency, consistent with the change in countries.json.


1866-1866: LGTM: Bulgaria correctly added to Eurozone countries.

BGR is properly positioned in alphabetical order between BEL and CYP.


5713-5713: LGTM: Proper EOF formatting.

The trailing newline ensures standard file formatting.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@prakhar-flow prakhar-flow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this PR, we should also make changes in the final folder (specifically the countries.json and regions.json files)

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)
data/final/regions.json (2)

1889-1912: Fix alphabetical ordering of Bulgarian language in Eurozone.

The Bulgarian language code "bg" is inserted after "cs", but alphabetically "bg" should precede "cs". This breaks the alphabetical sorting of the languages array.

🔎 Proposed fix to correct the sort order
     "languages": [
-      "cs",
       "bg",
+      "cs",
       "de",
       "el",

1618-1640: Remove BGN from regional currency lists to match Bulgaria's individual currency entry.

Bulgaria's country entry lists only EUR as its currency, but the aggregate regions (Europe, European Economic Area, and European Union) still include BGN. This creates an inconsistency in the data. Remove BGN from the currency arrays in these regional aggregates at lines 1621, 1728, 1814, and 5385 to align with Bulgaria's canonical currency entry.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b29a028 and 65cb0a0.

📒 Files selected for processing (2)
  • data/final/countries.json
  • data/final/regions.json
🔇 Additional comments (5)
data/final/countries.json (2)

3259-3259: LGTM: Proper EOF formatting.

The trailing newline ensures standard file formatting.


435-435: Revert Bulgaria's currency to BGN or defer this change.

Bulgaria's official Euro adoption is scheduled for January 1, 2026, not December 2025. The EU formally approved the accession on July 8, 2025, with the effective date set for January 1, 2026. The current change to "EUR" is premature for the current system time (December 2025) and should either be reverted to "BGN" or this file should be updated only on or after January 1, 2026.

Likely an incorrect or invalid review comment.

data/final/regions.json (3)

878-893: LGTM: Bulgaria region currency updated consistently.

The Bulgaria region entry correctly reflects the Euro currency, consistent with the change in countries.json.


1866-1866: LGTM: Bulgaria correctly added to Eurozone countries.

BGR is properly positioned in alphabetical order between BEL and CYP.


5713-5713: LGTM: Proper EOF formatting.

The trailing newline ensures standard file formatting.

Copy link
Copy Markdown
Contributor

@prakhar-flow prakhar-flow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@konstantin-petrukhnov-ge konstantin-petrukhnov-ge merged commit 31b8f12 into main Dec 30, 2025
2 checks passed
@konstantin-petrukhnov-ge konstantin-petrukhnov-ge deleted the COR-3430-BGN-to-EUR branch December 30, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants