Merged
Conversation
Contributor
Argo diff output for registry:===== /Service production/registry ======
11c11
< helm.sh/chart: flow-generic-1.6.62
---
> helm.sh/chart: flow-generic-1.6.64
===== apps/Deployment production/registry-live ======
16c16
< helm.sh/chart: flow-generic-1.6.62
---
> helm.sh/chart: flow-generic-1.6.64
===== datadoghq.com/DatadogMonitor datadog/registry-argorollout ======
162d161
< - generated:kubernetes
===== datadoghq.com/DatadogMonitor datadog/registry-errorrate ======
147d146
< - generated:kubernetes
===== networking.istio.io/Gateway production/registry-flow-io ======
17c17
< helm.sh/chart: flow-generic-1.6.62
---
> helm.sh/chart: flow-generic-1.6.64
===== networking.istio.io/VirtualService production/registry-rollout-live ======
12c12
< helm.sh/chart: flow-generic-1.6.62
---
> helm.sh/chart: flow-generic-1.6.64 |
📝 WalkthroughWalkthroughUpdates the Helm chart dependency version for charts/flow-generic from v2.0.20 to v2.0.24 in the ArgoCD Application manifest for the registry deployment. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@deploy/registry/app.yaml`:
- Line 47: Confirm with chart maintainers whether removing the
"generated:kubernetes" tag in targetRevision v2.0.24 is intentional; if it is,
update the ArgoCD application's ignoreDifferences block (the ignoreDifferences
stanza in app.yaml) to ignore the DatadogMonitor CRD tag drift by adding an
entry for group "datadoghq.com", kind "DatadogMonitor" that uses a
jqPathExpressions filter to ignore '.spec.tags[] | select(. ==
"generated:kubernetes")'; ensure the datadogMonitors configuration in
deploy/registry/values.yaml is referenced when coordinating this change.
gheine
approved these changes
Feb 24, 2026
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v2.0.20->v2.0.24Before merging:
Ensure your service is compatible with the new chart version
Review diff in PR with changes
Merge when ready to deploy this change
After merging, ArgoCD will automatically sync the new chart version.
Release Notes
flowcommerce/generic-charts (git@github.com:flowcommerce/generic-charts.git)
v2.0.24Compare Source
v2.0.23Compare Source
v2.0.22Compare Source
v2.0.21Compare Source
This PR has been generated by Renovate Bot.
Summary by CodeRabbit