Skip to content

Allow reupload of same file once the upload is complete#109

Merged
AidasK merged 3 commits intoflowjs:masterfrom
karan-kang:master
Jul 22, 2015
Merged

Allow reupload of same file once the upload is complete#109
AidasK merged 3 commits intoflowjs:masterfrom
karan-kang:master

Conversation

@karan-kang
Copy link
Copy Markdown
Contributor

Adding an option to override the default behavior of ignore reupload of the same file.

Karanvir Kang added 2 commits June 29, 2015 12:33
Adding an option to allow reupload of same file once the file upload is complete.
@AidasK
Copy link
Copy Markdown
Member

AidasK commented Jun 29, 2015

Tests ar not passing because you are using opts instead of this.opts, please fix and it will be merged. Thanks

Fixing opts reference error
@AidasK
Copy link
Copy Markdown
Member

AidasK commented Jul 21, 2015

Could you add documentation for this option to the readme?

@karan-kang
Copy link
Copy Markdown
Contributor Author

Added documentation for allowDuplicateUploads option.
#113

AidasK added a commit that referenced this pull request Jul 22, 2015
feat: allow reupload of same file once the upload is complete
@AidasK AidasK merged commit ce7b33c into flowjs:master Jul 22, 2015
@lucretiu
Copy link
Copy Markdown

Could you please add this merge into the version in the dist directory? Installing Flow using bower ignores the src directory, which actually contains the Flow version that allows this behaviour. I spent an hour or so trying to find why duplicate downloads were not accepted, only to find out that the version I have installed, even though it's "the latest" one, is not the latest one :(
It's even more confusing because the README which is shown on github says that the option is available.

@AidasK
Copy link
Copy Markdown
Member

AidasK commented Sep 14, 2015

Sorry for this confusion, I will try to release this as soon as possible.

@soccerloway
Copy link
Copy Markdown

Hi, I need using this option in my project, but I found this option didn't merge into the version in the dist directory. So I tried to use the version in the src directory. Bad luck, it throw an error said ' domNode.appendChild is not a function '. I also use ng-flow.js in my project.
Help me, thx~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants