Adding adding module to app dependencies in installation guide #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, it is good to add an explanation about what files to include in index.html
Member
|
Thanks for contribution, but you have mixed repositories. I think this request should go to https://github.com/resumable2/ng-resumable |
Author
|
Ohhh oops... :) i've now added it to the right one. |
Member
|
Yea, i saw. I understand that documentation is unfinished. If you think it is missing something, just prepare other pull requests. |
AidasK
pushed a commit
that referenced
this pull request
Jan 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, it is good to add an explanation about what files to include in index.html