call generateUniqueIdentifier once per added file#218
Merged
AidasK merged 2 commits intoflowjs:masterfrom Apr 11, 2017
Merged
Conversation
Contributor
Author
|
I found this because I was using generateUniqueIdentifier to request a unique identifier from the server, and flow was performing two successive GETs. |
AidasK
requested changes
Apr 11, 2017
| * @type {string} | ||
| */ | ||
| this.uniqueIdentifier = flowObj.generateUniqueIdentifier(file); | ||
| this.uniqueIdentifier = uniqueIdentifier; |
Member
There was a problem hiding this comment.
BC: please change this line to:
uniqueIdentifier === undefined ? flowObj.generateUniqueIdentifier(file): uniqueIdentifier;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addFiles calls generateUniqueIdentifier, but then FlowFile also calls generateUniqueIdentifier. Not a big deal, but an inefficiency nonetheless.