Avoid ReferenceError window is not defined in the node environment #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AidasK
reviewed
Oct 5, 2018
| console.warn('Flowjs needs window and document objects to work'); | ||
| } | ||
| // ie10+ | ||
| var ie10plus = window.navigator.msPointerEnabled; |
Member
There was a problem hiding this comment.
This is still going to break with an error here. Shouldn't we call return; after console.warn?
Contributor
Author
There was a problem hiding this comment.
Oh, god how could I? :-) Of course you are right. When I tested it I had return. Then I put there the warning but forgot to keep the return. Going to update PR.
MartinNuc
force-pushed
the
universal-support
branch
from
2aaaf0b to
6229ef3
Compare
Member
|
Merged. Do you need a build in dist/ too? |
Member
|
Nm, made a new build released under 2.13.1 |
Contributor
Author
|
Ya I need it also in dist. Thank you. |
Contributor
Author
|
@AidasK I just tried that and it looks like the 2.13.1 is not published to npm repository: https://www.npmjs.com/package/@flowjs/flow.js Can you please publish it? I could probably publish it on my own but don't want to mess anything :-) |
Member
|
Published. I haven't done this either, but hope it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve issue with server side rendering I need flow.js to be able to survive missing
windowanddocumentobjects.I am not sure how to cover this by tests however :-( any suggestions?