[Call Graph] feat provide call graph for a selective id only #2176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to extract a sub call graph from a full call graph based on selective entry point IDs. The implementation allows users to create a filtered call graph containing only the nodes reachable from specified starting points.
- Implements
getSubCallGraphfunction to extract sub-graphs from call graphs - Adds comprehensive test coverage for the new sub-graph extraction feature
- Exports helper function
mapProblematicNodesToIdsfor better test utility reuse - Refactors
slice-call.tsfor improved code maintainability
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/dataflow/graph/call-graph.ts |
Adds getSubCallGraph function to extract sub call graphs from given entry points using depth-first traversal |
test/functionality/dataflow/call-graph/call-graph-sub.test.ts |
Introduces new test suite for sub call graph extraction with test helper function |
test/functionality/_helper/shell.ts |
Exports mapProblematicNodesToIds helper function with documentation for reuse in tests |
src/slicing/static/slice-call.ts |
Refactors code by extracting constant PotentialFollowOnReturn, using destructuring, and moving fingerprint calculation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EagleoutIce
deleted the
2171-feat-provide-call-graph-for-a-selective-id-only
branch
Member
Author
|
This pull request is included in v2.8.2 (see Release v2.8.2 (Project Discovery Fixes, Call-Graph Slices)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.