doc: add call graph generation to benchmark page#2358
Merged
EagleoutIce merged 4 commits intomainfrom Feb 22, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for call graph generation and benchmarking to flowR's performance measurement infrastructure. The changes integrate call graph extraction into the benchmark pipeline, similar to how control flow graph extraction is currently handled, and update the benchmark visualization page to display call graph timing metrics.
Changes:
- Added
--cgCLI flag to enable call graph extraction during benchmarking - Integrated call graph extraction timing into the benchmark statistics tracking system
- Updated benchmark visualization page to display call graph extraction metrics alongside other measurements
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| wiki/stats/benchmark/index.html | Added "Extract call graph" to the benchmark chart rendering |
| test/performance/run-suite.sh | Added --cg flag to the benchmark command |
| src/cli/common/options.ts | Added cg CLI option definition for benchmark commands |
| src/cli/benchmark-app.ts | Added cg option handling to pass through to helper process |
| src/cli/benchmark-helper-app.ts | Added logic to conditionally extract call graph when cg option is set |
| src/benchmark/slicer.ts | Added extractCG() method and call graph timing tracking (contains critical bug) |
| src/benchmark/stats/stats.ts | Added callGraphTimePerToken field to OptionalSlicerMeasurements and SlicerStats |
| src/benchmark/stats/print.ts | Added call graph timing output to stats printing functions |
| src/benchmark/summarizer/data.ts | Added callGraphTimePerToken field to UltimateSlicerStats interface |
| src/benchmark/summarizer/second-phase/process.ts | Added call graph timing aggregation in summarization phase |
| src/util/summarizer.ts | Modernized array access using .at(-1) |
| src/documentation/wiki-mk/doc-context.ts | Modernized string operations and refactored link generation |
| src/documentation/wiki-linter.ts | Modernized string operations using replaceAll |
| src/documentation/wiki-dataflow-graph.ts | Modernized string operations using replaceAll |
| src/documentation/doc-readme.ts | Used String.raw for BibTeX template literal to avoid escaping issues |
| src/cli/wiki.ts | Modernized timestamp retrieval using Date.now() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EagleoutIce
deleted the
2170-add-call-graph-generation-to-benchmark-page
branch
Member
Author
|
This pull request is included in v2.9.13 (see Release v2.9.13 (FlowrConfig helper, General Bug-Fixes)). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.