2326 interval pentagon ai interval condition semantics#2359
Merged
schuler-henry merged 28 commits intostaging/pentagon-aifrom Mar 19, 2026
Merged
Conversation
…' into 2326-interval-pentagon-ai-interval-condition-semantics
…-semantics # Conflicts: # src/abstract-interpretation/absint-visitor.ts # src/documentation/wiki-absint.ts
- StateAbstractDomain
- Updated equal and leq to use Ternary return value
- Updated mutable version to also accept bottom property
- Abstract Visitor
- Added abstract getBottomValue method => required for getAbstractValue
- Updated getAbstractValue method to return bottom if the state is bottom
- When resolving symbol origins, it is also checked if their state is bottom (and therefore returning bottom as this information is lost in the current state)
- Updated interval expression semantics to return bottom if the state is bottom
…' into 2326-interval-pentagon-ai-interval-condition-semantics # Conflicts: # src/abstract-interpretation/absint-visitor.ts # src/abstract-interpretation/interval/numeric-inference.ts
…' into 2326-interval-pentagon-ai-interval-condition-semantics # Conflicts: # src/abstract-interpretation/absint-visitor.ts
…' into 2326-interval-pentagon-ai-interval-condition-semantics # Conflicts: # src/abstract-interpretation/interval/numeric-inference.ts
Result is now applied to variable origins. Condition value undefined is now correctly handled. Added further test cases for while loops.
Collaborator
Author
|
@OliverGerstl @EagleoutIce die Condition-Semantics stehen soweit. |
Base automatically changed from
2319-interval-pentagon-ai-interval-expression-semantics
to
staging/pentagon-ai
February 24, 2026 17:38
…erval-condition-semantics # Conflicts: # src/abstract-interpretation/interval/expression-semantics.ts
…erval-condition-semantics
Unknown side effects can currently cause underapproximation when used in loops
EagleoutIce
approved these changes
Mar 12, 2026
Member
EagleoutIce
left a comment
EagleoutIce
left a comment
There was a problem hiding this comment.
For a merge to staging this is fine for me, but maybe we want to wait for @OliverGerstl?
OliverGerstl
approved these changes
Mar 17, 2026
Collaborator
OliverGerstl
left a comment
OliverGerstl
left a comment
There was a problem hiding this comment.
Looks good to me :)
Just some minor things and comments
OliverGerstl
approved these changes
Mar 19, 2026
schuler-henry
deleted the
2326-interval-pentagon-ai-interval-condition-semantics
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Condition semantics for: ==, <, >, is.na and their negations