Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors several dataflow-related utilities into centralized “helper objects” (notably Dataflow, CallGraph, and Mermaid) and introduces a new provenance query to extract a transformation subgraph for a given variable/criterion.
Changes:
- Add
Dataflow/GraphHelperabstractions and migrate visualization/diff/invert/resolve helpers to them. - Introduce
provenancequery (format + executor) and add a system test for provenance behavior. - Refactor slicing criterion parsing helpers and migrate slice-direction enum to
src/util/slice-direction.ts.
Reviewed changes
Copilot reviewed 164 out of 165 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/util/mermaid/cfg.ts |
Refactors mermaid escaping/URL plumbing (but currently returns escaped source instead of URL). |
src/slicing/criterion/parse.ts |
Introduces SingleSlicingCriterion / SlicingCriteria helper objects (but convertAll has an unsafe/incorrect fallback). |
src/queries/catalog/provenance-query/* |
Adds provenance query parsing + execution (but criterion resolution + restrictFdef handling need fixes). |
src/queries/catalog/static-slice-query/static-slice-query-executor.ts |
Updates slice execution to use new criteria helpers (but now risks silently accepting invalid criteria). |
src/r-bridge/roxygen2/documentation-provider.ts |
Changes to use RNode.documentation (introduces an avoidable circular runtime dependency). |
src/documentation/wiki-dataflow-graph.ts |
Documentation update referencing Dataflow helper object (contains a typo). |
test/**/* |
Broad test updates to use new helpers (Dataflow.visualize..., SingleSlicingCriterion.parse, etc.) and adds provenance tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EagleoutIce
changed the title
EagleoutIce
deleted the
2386-get-a-transformation-sub-graph-for-a-given-variable
branch
Member
Author
|
This pull request is included in v2.9.14 (see Release v2.9.14 (Stop-Call Linter Rule, Dataflow Object-Helper Redesign)). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helper Objects:
Dataflow,GraphHelper,CallGraph,MermaidSingleSlicingCriterion,SlicingCriteriaDataflowInformationMore helper methods for RNode friends,
SourcePosition, ...New
provenancecalculation and query