Skip to content

feat: track multiple input types at once#2408

Merged
EagleoutIce merged 2 commits intomainfrom
2406-support-more-than-one-type-per-trace-use-set
Mar 21, 2026
Merged

feat: track multiple input types at once#2408
EagleoutIce merged 2 commits intomainfrom
2406-support-more-than-one-type-per-trace-use-set

Conversation

@EagleoutIce
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates flowR’s input-sources tracking to preserve multiple observed input types (instead of collapsing them into a single “worst” type), and propagates that change through the linter, query formatting, tests, and generated documentation.

Changes:

  • Change InputSource.type from a single InputType to InputType[] and adjust the classifier to accumulate unique observed types.
  • Update problematic-eval linter logic/formatting and the input-sources query ASCII formatter to handle arrays.
  • Refresh tests and regenerated wiki/README outputs to reflect the new result shape.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/queries/catalog/input-sources-query/simple-input-classifier.ts Core change: track a set of observed input types and update classification logic accordingly.
src/linter/rules/problematic-eval.ts Adapt linter evaluation/formatting to handle multi-type input sources.
src/queries/catalog/input-sources-query/input-sources-query-format.ts Adjust REPL/ascii summarizer output to print array types.
test/functionality/dataflow/query/input-source.test.ts Update expectations to array types; add a new combined-types test.
test/functionality/linter/lint-problematic-eval.test.ts Update expected linter result shape to array types.
wiki/Core.md Regenerated docs reflecting v2.10.0 and updated outputs.
wiki/Capabilities.md Regenerated capabilities documentation.
wiki/[Linting Rule] Problematic Eval.md Regenerated linter rule docs reflecting array-typed sources.
README.md Regenerated/readjusted example outputs and timings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/queries/catalog/input-sources-query/simple-input-classifier.ts
Comment thread src/queries/catalog/input-sources-query/simple-input-classifier.ts Outdated
Comment thread test/functionality/dataflow/query/input-source.test.ts Outdated
@EagleoutIce EagleoutIce merged commit 2b59864 into main Mar 21, 2026
19 checks passed
@EagleoutIce EagleoutIce deleted the 2406-support-more-than-one-type-per-trace-use-set branch March 21, 2026 21:25
@EagleoutIce
Copy link
Copy Markdown
Member Author

This pull request is included in v2.10.1 (see Release v2.10.1 (Support Multiple Input Sources)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support more than one type per trace (use set)

2 participants