feat: track multiple input types at once#2408
Merged
EagleoutIce merged 2 commits intomainfrom Mar 21, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates flowR’s input-sources tracking to preserve multiple observed input types (instead of collapsing them into a single “worst” type), and propagates that change through the linter, query formatting, tests, and generated documentation.
Changes:
- Change
InputSource.typefrom a singleInputTypetoInputType[]and adjust the classifier to accumulate unique observed types. - Update
problematic-evallinter logic/formatting and theinput-sourcesquery ASCII formatter to handle arrays. - Refresh tests and regenerated wiki/README outputs to reflect the new result shape.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/queries/catalog/input-sources-query/simple-input-classifier.ts |
Core change: track a set of observed input types and update classification logic accordingly. |
src/linter/rules/problematic-eval.ts |
Adapt linter evaluation/formatting to handle multi-type input sources. |
src/queries/catalog/input-sources-query/input-sources-query-format.ts |
Adjust REPL/ascii summarizer output to print array types. |
test/functionality/dataflow/query/input-source.test.ts |
Update expectations to array types; add a new combined-types test. |
test/functionality/linter/lint-problematic-eval.test.ts |
Update expected linter result shape to array types. |
wiki/Core.md |
Regenerated docs reflecting v2.10.0 and updated outputs. |
wiki/Capabilities.md |
Regenerated capabilities documentation. |
wiki/[Linting Rule] Problematic Eval.md |
Regenerated linter rule docs reflecting array-typed sources. |
README.md |
Regenerated/readjusted example outputs and timings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
This pull request is included in v2.10.1 (see Release v2.10.1 (Support Multiple Input Sources)). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.