refactor: drop the pre analysis step#2421
Merged
EagleoutIce merged 2 commits intomainfrom Apr 1, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the explicit “pre analysis” orchestration step (resolvePreAnalysis) from the analyzer context and updates call sites/tests/documentation accordingly, simplifying context usage by relying on existing lazy resolution behavior in the loading-order and dependency contexts.
Changes:
- Removed
FlowrAnalyzerContext.resolvePreAnalysis()and all known invocations across src and tests. - Updated documentation to no longer reference the removed pre-analysis step.
- Minor cleanup in CLI code (plus one newly introduced direct console log in REPL dataflow command).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/functionality/project/plugin/news-file.test.ts | Removes pre-analysis call from test setup. |
| test/functionality/project/plugin/namespace-file.test.ts | Removes pre-analysis call from test setup. |
| test/functionality/project/plugin/license-file.test.ts | Removes pre-analysis call from test setup. |
| test/functionality/project/plugin/description-file.test.ts | Removes pre-analysis call from helper context setup. |
| src/queries/catalog/files-query/files-query-executor.ts | Stops forcing pre-analysis before file queries. |
| src/project/flowr-analyzer-builder.ts | Removes builder-time pre-analysis call (comment now stale). |
| src/project/context/flowr-analyzer-context.ts | Deletes resolvePreAnalysis API and related docs. |
| src/documentation/wiki-analyzer.ts | Removes documentation reference to resolvePreAnalysis. |
| src/cli/repl/commands/repl-dataflow.ts | Adds a console.log of internal memory state in :dataflowsilent. |
| src/cli/flowr.ts | Minor object property shorthand cleanup when calling repl. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
This pull request is included in v2.10.2 (see Release v2.10.2 (Pipes, Purrr, Dplyr, NSE, and more :))). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.