docs: fix invalid new-issue link in README#9
Closed
networkhermit wants to merge 2 commits intoflox:mainfrom
networkhermit:docs/fix-invalid-new-issue-link
Closed
docs: fix invalid new-issue link in README#9networkhermit wants to merge 2 commits intoflox:mainfrom networkhermit:docs/fix-invalid-new-issue-link
networkhermit wants to merge 2 commits intoflox:mainfrom
networkhermit:docs/fix-invalid-new-issue-link
Conversation
ysndr
approved these changes
Mar 24, 2023
Contributor
ysndr
left a comment
ysndr
left a comment
There was a problem hiding this comment.
Hey @networkhermit
Thank you very much for your contribution.
Since your pull request got accepted, your changes have been merged internally and will be part of the next release.
gilmishal
added a commit
that referenced
this pull request
Mar 19, 2026
Change Flox::get_handle() from Result<String, AuthError> to Option<String>, collapsing Expired (which still has a valid handle) into Some and NotAuthenticated into None. Callers that need the full error (e.g. ensure_auth) now call auth_strategy.get_handle() directly. Other callers are simplified by removing manual match/ok() patterns. Addresses review comments #9 (error swallowing in floxmeta_branch) and #13 (typed auth state). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gilmishal
added a commit
that referenced
this pull request
Mar 26, 2026
Change Flox::get_handle() from Result<String, AuthError> to Option<String>, collapsing Expired (which still has a valid handle) into Some and NotAuthenticated into None. Callers that need the full error (e.g. ensure_auth) now call auth_strategy.get_handle() directly. Other callers are simplified by removing manual match/ok() patterns. Addresses review comments #9 (error swallowing in floxmeta_branch) and #13 (typed auth state). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
new-issue link in README refers to private repo
Proposed Changes
fix the new-issue link in README
Checks