Check if the date range is already parsed#42
Closed
noxer wants to merge 1 commit intoflrs:masterfrom
noxer:master
Closed
Check if the date range is already parsed#42noxer wants to merge 1 commit intoflrs:masterfrom noxer:master
noxer wants to merge 1 commit intoflrs:masterfrom
noxer:master
Conversation
Collaborator
|
Hi @noxer , I'm not 100% sure that your workaround is correct because when we use the display_date_range we need to be sure that format of time is in the correct form, as same form generated by graph. |
Author
|
Without the fix I'm getting this exception when calling The code still checks for the correct format of the timestamps, it just skips that check if the timestamp has already been converted into a Date object. |
tanganellilore
added a commit
that referenced
this pull request
Jan 10, 2020
Collaborator
|
Close this merge with new release of visavail 1.3.0. Enjoy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've encountered an error when attempting to use
updateGraph. The visavail tries to match the Date objects it parsed in the firstgeneratecall with the regexes. This PR adds a type check to prevent this.Caveat: I was unable to generate the minified version due to my enviroment here.