Bug: Flucoma build fail to checkout fmt master branch

[nicobou]

Please tell us what you were doing! You can include code and files by drag and dropping them into the text area.

When I build Flucoma from source, main branch, results in this error.

fatal: invalid reference: master
CMake Error at fmt-subbuild/fmt-populate-prefix/tmp/fmt-populate-gitclone.cmake:49 (message):
  Failed to checkout tag: 'master'

It seems that fmt library changed the name of the master branch into main. So when I manually change the expected fmt branch name in the Flucoma CMakeLists.txt with main: it fix the compilation issue:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 74cee56b..a4181575 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -100,7 +100,7 @@ FetchContent_Declare(
   GIT_SHALLOW TRUE  
   GIT_REPOSITORY https://github.com/fmtlib/fmt
   GIT_PROGRESS TRUE
-  GIT_TAG master 
+  GIT_TAG main
   EXCLUDE_FROM_ALL
 )

What was the expected result?

Success with the Flucoma build

What was the actual result?

Build failed

What operating system were you using?

Linux

Operating system version

ubuntu 24.04

FluCoMa Version

main branch (commit 532ea53)

[tremblap]

wow this is strange, I wonder when they changed it. It must be very recently since we built on the CI last week... @weefuzzy I don't see any problem of merging #342 but you are the senior steward of the codebase :) I've started to run the tests on the PRs they should be done by the time you read this.

[tremblap]

and @nicobou merci!

[nicobou]

Mon plaisir ! et merci pour Flucoma, I love it !