feat: add a progress bar to download#302
Conversation
d3d28db to
fcd9718
Compare
fcd9718 to
92f6763
Compare
|
This is expected as the |
92f6763 to
e60983f
Compare
|
Hmmmm, i miss the point of adding a progress bar, ETA and percentage that don't work though. |
mdimopoulos
left a comment
There was a problem hiding this comment.
See previous comment
|
I understand your disappointment but this is due to the server limitation not to the algorithm, we cant know the size in advance except if we add it to the json file. The algorithm is correct when the total size is reported by the server. I initially used I can decrease the frequence of updates if you like. I would recommend 5s instead to have a feeling of download progress when its working fine, are you okay ? |
Thanks for the clarifications. I agree to an update internal of 5 seconds. |
|
As a general comment, please check my previous code comments using "Files changed" tab. Under "conversation" tab it is impossible to know which line of code each one refers to. |
0f8d011 to
900d6f1
Compare
In order to track the download progress, add a download progress bar to the terminal output.
900d6f1 to
5a85c8a
Compare

In order to track the download progress,
add a download progress bar to the terminal output.