cmake: resolve build issues#18
Conversation
Signed-off-by: Patrick Stephens <pat@calyptia.com>
Signed-off-by: Patrick Stephens <pat@calyptia.com>
Signed-off-by: Patrick Stephens <pat@calyptia.com>
Signed-off-by: Patrick Stephens <pat@calyptia.com>
| set(CFL_INSTALL_BINDIR "bin") | ||
| set(CFL_INSTALL_LIBDIR "lib") | ||
| else() | ||
| set(CFL_INSTALL_BINDIR ${CMAKE_INSTALL_FULL_BINDIR}) |
There was a problem hiding this comment.
I just followed what Fluent Bit did here but you may want another specific directory.
| - uses: actions/checkout@v3 | ||
| - uses: ludeeus/action-shellcheck@master | ||
| with: | ||
| ignore_paths: lib |
There was a problem hiding this comment.
The scripts in xxhash have a few "issues" so ignoring any dependencies here.
| env: | ||
| CC: ${{ matrix.compiler }} | ||
|
|
||
| build-analysis-tests: |
There was a problem hiding this comment.
Taken from cmetrics/ctraces
| postgresql-libs postgresql-devel postgresql-server postgresql && \ | ||
| wget http://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm && \ | ||
| rpm -ivh epel-release-latest-7.noarch.rpm && \ | ||
| yum -y update |
There was a problem hiding this comment.
Simplified and reduced dependencies required to speed up builds
| - name: Run compilation | ||
| run: | | ||
| cmake -DCFL_DEV=on . | ||
| make |
There was a problem hiding this comment.
Does this run in build/?
Could you use cmake --build . instead of make?
There was a problem hiding this comment.
Yeah can do, I just left it as it was before in the other builds.
| @@ -75,6 +91,7 @@ jobs: | |||
| CTEST_OUTPUT_ON_FAILURE=1 make test | |||
There was a problem hiding this comment.
Don't we use ctest for this?
There was a problem hiding this comment.
I think this should be fine, since cmake commands generate a Makefile test command that uses ctest
There was a problem hiding this comment.
But that doesn't work in windows right?
3 participants
Resolves #17
Missing variables were triggering failures so have added those and also provided an extra test case.
Added linting plus sanitiser calls for unit tests.