compat: Fix MSYS2 platform build#26
Merged
Merged
Conversation
To build with MSYS2, we don't need to use these trivial macros on cfl_compat.h.
Otherwise, they cause the following errors:
```log
In file included from C:\Users\cosmo\Documents\GitHub\cfl\src\cfl_time.c:29:
C:/Users/cosmo/Documents/GitHub/cfl/include/cfl/cfl_compat.h:40:16: error: '__tzname' declared as function returning an array
40 | #define tzname _tzname
| ^~~~~~~
C:/Users/cosmo/Documents/GitHub/cfl/include/cfl/cfl_compat.h:40:16: error: conflicting types for '__tzname'; have 'int(
'
C:/Ruby31-x64/msys64/ucrt64/include/time.h:123:26: note: previous declaration of '__tzname' with type 'char **(void)'
123 | _CRTIMP char **__cdecl __tzname(void);
| ^~~~~~~~
C:/Users/cosmo/Documents/GitHub/cfl/include/cfl/cfl_compat.h:39:18: error: expected '{' before '(' token
39 | #define timezone _timezone
| ^~~~~~~~~
C:/Users/cosmo/Documents/GitHub/cfl/include/cfl/cfl_compat.h:39:18: error: expected '{' before '(' token
39 | #define timezone _timezone
| ^~~~~~~~~
mingw32-make[2]: *** [src\CMakeFiles\cfl-static.dir\build.make:121: src/CMakeFiles/cfl-static.dir/cfl_time.c.obj] Error 1
mingw32-make[1]: *** [CMakeFiles\Makefile2:157: src/CMakeFiles/cfl-static.dir/all] Error 2
```
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Contributor
Author
|
This can be tested by |
cosmo0920
force-pushed
the
fix-errors-on-msys2
branch
9 times, most recently
from
8aca949 to
201536a
Compare
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
cosmo0920
force-pushed
the
fix-errors-on-msys2
branch
from
201536a to
a36c043
Compare
From POSIX specification, fputs should non-negative number if succeeded. When it fails, it should return EOF not negative number. Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
cosmo0920
force-pushed
the
fix-errors-on-msys2
branch
from
659ad9f to
afb8817
Compare
patrick-stephens
approved these changes
Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To build with MSYS2, we don't need to use these trivial macros on cfl_compat.h.
Otherwise, they cause the following errors:
Signed-off-by: Hiroshi Hatake hatake@calyptia.com