Skip to content

raspbian11: Use signed-by style on GPG key for apt repo#1147

Closed
cosmo0920 wants to merge 2 commits into
masterfrom
cosmo0920-use-signed-by-on-apt-line-on-raspbian11
Closed

raspbian11: Use signed-by style on GPG key for apt repo#1147
cosmo0920 wants to merge 2 commits into
masterfrom
cosmo0920-use-signed-by-on-apt-line-on-raspbian11

Conversation

@cosmo0920
Copy link
Copy Markdown
Contributor

@cosmo0920 cosmo0920 commented Jul 3, 2023

No description provided.

@cosmo0920
raspbian11: Use signed-by style on GPG key for apt repo
0f31f80 
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
patrick-stephens
patrick-stephens reviewed Jul 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's only have one way to do it.

Could you update the other Debian targets as well @cosmo0920 to be consistent?
@ehienabs can we have a common section inserted rather than duplicating it everywhere?

Comment thread installation/linux/raspbian-raspberry-pi.md
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the Stale label Oct 3, 2023
@github-actions github-actions Bot removed the Stale label Mar 26, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 24, 2025

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the Stale label Jun 24, 2025
@github-actions github-actions Bot removed the Stale label Oct 1, 2025
@eschabell eschabell self-assigned this Oct 21, 2025
@eschabell eschabell added waiting-for-user Waiting for user/contributors feedback or requested changes conflict Waiting on conflict to be resolved by contributor labels Oct 21, 2025
@eschabell
Copy link
Copy Markdown
Collaborator

eschabell commented Oct 21, 2025

@cosmo0920 can you resolve the conflicts here and I can merge for you?

@eschabell eschabell removed the waiting-for-user Waiting for user/contributors feedback or requested changes label Dec 3, 2025
@eschabell eschabell added the waiting-on-review Waiting on a review from mainteners label May 27, 2026
@eschabell
docs: installation: linux: raspbian: fix GPG key sections and style i…
ed23e0d 
…ssues

  - Add deprecation warning for apt-key (old style) pointing to new style section
  - Replace sudo bash redirect with sudo tee pipeline in new style command
  - Replace keyrings directory reference with explicit path
  - Fix vale failures for many phrases in the text

  Applies to #1147

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d739ee61-cd2a-4a21-adde-7a0338e4da1b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cosmo0920-use-signed-by-on-apt-line-on-raspbian11

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell eschabell added Stale and removed waiting-on-review Waiting on a review from mainteners labels May 27, 2026
@eschabell
Copy link
Copy Markdown
Collaborator

eschabell commented May 27, 2026

Been doing some research here @cosmo0920 and I'm going to just close this as your branch is effectively obsolete (from 2023):

  1. The file was moved in September 2025 from installation/linux/ to installation/downloads/linux/ — the branch is targeting a path that no longer exists in master.
  2. The file has been significantly rewritten in master. The current version at the new path is much cleaner.
  3. The signed-by change is NOT in the new file — Raspbian 11 (Bullseye) at line 32 still uses a plain deb line without signed-by. So the original intent of the branch is still a valid fix, but it needs to be applied to the new file location.

I'm going to open a fresh PR for this and target the newer situation for the file while marking this STALE.

@eschabell eschabell closed this May 27, 2026
@eschabell eschabell mentioned this pull request May 27, 2026
Open
eschabell added a commit to eschabell/fluent-bit-docs-fork that referenced this pull request May 27, 2026
@eschabell
docs: installation: downloads: linux: raspbian: use signed-by for Bul…
4507ad0 
…lseye apt source

  - Replace apt-key add with gpg --dearmor | sudo tee to store key in /usr/share/keyrings
  - Add signed-by=/usr/share/keyrings/fluentbit-keyring.gpg to Raspbian 10 (Buster) apt source entry
  - Add signed-by=/usr/share/keyrings/fluentbit-keyring.gpg to Raspbian 11 (Bullseye) apt source entry
  - Add signed-by=/usr/share/keyrings/fluentbit-keyring.gpg to Raspbian 12 (Bookworm) apt source entry
  - Wrap Bookworm, Bullseye, and Buster codenames in backticks in section headings

  Replaces fluent#1147

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@patrick-stephens patrick-stephens deleted the cosmo0920-use-signed-by-on-apt-line-on-raspbian11 branch May 28, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrick-stephens patrick-stephens patrick-stephens left review comments

@eschabell eschabell Awaiting requested review from eschabell eschabell will be requested when the pull request is marked ready for review eschabell is a code owner

Assignees

@eschabell eschabell

Labels

conflict Waiting on conflict to be resolved by contributor Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cosmo0920 @eschabell @patrick-stephens