Skip to content

Conversation

@adiforluls
Copy link
Member

@adiforluls adiforluls commented Aug 30, 2023

This PR is for documentation of Oracle Cloud Infrastructure Logging Analytics output plugin.
Corresponds to fluent/fluent-bit#7830

Signed-off-by: adiforluls <aditya.b.bharadwaj@oracle.com>
@adiforluls
Copy link
Member Author

cc: @edsiper @patrick-stephens

Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few niggles.

How would you suspect people would use this? Wondering if we should expand the examples away from just dummy input to real scenarios?

@patrick-stephens
Copy link
Contributor

Please also update the description and link back to the original PR in the code.

Signed-off-by: adiforluls <aditya.b.bharadwaj@oracle.com>
Signed-off-by: adiforluls <aditya.b.bharadwaj@oracle.com>
Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the description and link back to the original code change PR too.

@adiforluls
Copy link
Member Author

Done @patrick-stephens

@adiforluls
Copy link
Member Author

Hi @patrick-stephens , the main code is merged. This PR can be merged now

@patrick-stephens
Copy link
Contributor

Hi @patrick-stephens , the main code is merged. This PR can be merged now

Not until it's in a release usually, otherwise it'll confuse people expecting to use it with the official binaries.

@patrick-stephens patrick-stephens merged commit 1617bc3 into fluent:master Sep 27, 2023
TomlinfreeGit pushed a commit to TomlinfreeGit/fluent-bit-docs that referenced this pull request Oct 28, 2025
* public docs for oci logging analytics

Signed-off-by: adiforluls <aditya.b.bharadwaj@oracle.com>

* address review comments

Signed-off-by: adiforluls <aditya.b.bharadwaj@oracle.com>

* rename plugin

Signed-off-by: adiforluls <aditya.b.bharadwaj@oracle.com>

---------

Signed-off-by: adiforluls <aditya.b.bharadwaj@oracle.com>
Signed-off-by: Tom <yao.lin@siemens.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants