-
Notifications
You must be signed in to change notification settings - Fork 540
public docs for oci logging analytics #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
public docs for oci logging analytics #1186
Conversation
Signed-off-by: adiforluls <aditya.b.bharadwaj@oracle.com>
patrick-stephens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few niggles.
How would you suspect people would use this? Wondering if we should expand the examples away from just dummy input to real scenarios?
|
Please also update the description and link back to the original PR in the code. |
Signed-off-by: adiforluls <aditya.b.bharadwaj@oracle.com>
Signed-off-by: adiforluls <aditya.b.bharadwaj@oracle.com>
patrick-stephens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the description and link back to the original code change PR too.
|
Done @patrick-stephens |
|
Hi @patrick-stephens , the main code is merged. This PR can be merged now |
Not until it's in a release usually, otherwise it'll confuse people expecting to use it with the official binaries. |
* public docs for oci logging analytics Signed-off-by: adiforluls <aditya.b.bharadwaj@oracle.com> * address review comments Signed-off-by: adiforluls <aditya.b.bharadwaj@oracle.com> * rename plugin Signed-off-by: adiforluls <aditya.b.bharadwaj@oracle.com> --------- Signed-off-by: adiforluls <aditya.b.bharadwaj@oracle.com> Signed-off-by: Tom <yao.lin@siemens.com>
This PR is for documentation of Oracle Cloud Infrastructure Logging Analytics output plugin.
Corresponds to fluent/fluent-bit#7830