Skip to content

Conversation

@patrick-stephens
Copy link
Contributor

If you do not have a unique db file across multiple tail inputs then you may get inconsistent behaviour, e.g. https://fluent-all.slack.com/archives/C0CTQGHKJ/p1758561924366279?thread_ts=1758224398.125199&cid=C0CTQGHKJ

Signed-off-by: Patrick Stephens <pat@fluent.do>
@patrick-stephens patrick-stephens requested review from a team as code owners September 23, 2025 11:24
Signed-off-by: Patrick Stephens <pat@fluent.do>
@patrick-stephens
Copy link
Contributor Author

patrick-stephens commented Sep 23, 2025

I take issue with requiring contractions - any reason for it @alexakreizinger ?

  Warning: [vale] reported by reviewdog 🐶
  [FluentBit.Contractions] Feel free to use 'it's' instead of 'it is'.
  
  Raw Output:
  {"message": "[FluentBit.Contractions] Feel free to use 'it's' instead of 'it is'.", "location": {"path": "pipeline/inputs/tail.md", "range": {"start": {"line": 78, "column": 56}}}, "severity": "INFO"}
  reviewdog: found at least one result in diff
Error: Vale and reviewdog exited with status code: 1

Signed-off-by: Patrick Stephens <pat@fluent.do>
@patrick-stephens patrick-stephens merged commit 2a4ce32 into master Sep 23, 2025
7 checks passed
@patrick-stephens patrick-stephens deleted the db_tail_restrictions branch September 23, 2025 12:19
@alexakreizinger
Copy link
Member

@patrick-stephens not required, just suggested, so feel free to take or ignore the suggestion as you see fit :) although instead of warning there is a suggestion-level vale message we could implement instead—what do you think @esmerel?

@alexakreizinger
Copy link
Member

actually, looking more closely at the linter message: I think the "warning" part is just a generic message from reviewdog, because in the raw output I see "severity": "INFO". so we might not be able to change the linter message itself, but regardless, no pressure to use contractions unless you want to.

TomlinfreeGit pushed a commit to TomlinfreeGit/fluent-bit-docs that referenced this pull request Oct 28, 2025
* tail: ensure db file is unique

Signed-off-by: Patrick Stephens <pat@fluent.do>

* fix: resolve review comments

Signed-off-by: Patrick Stephens <pat@fluent.do>

* fix: resolve review comments

Signed-off-by: Patrick Stephens <pat@fluent.do>

---------

Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Tom <yao.lin@siemens.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants