Skip to content

Conversation

@eschabell
Copy link
Collaborator

@eschabell eschabell commented Dec 2, 2025

  • Add missing config parameters: db.journal_mode, db.locking, dns_retries, dns_wait_time
  • Fix tls.verify default from 'On' to 'true' to match source
  • Fix kube_namespace default from 'all' to none
  • Sort parameters alphabetically
  • Align table format with other input plugin docs
  • Expand tls.debug description with all debug levels

Fixes #2272.

Summary by CodeRabbit

Documentation

  • Updated Kubernetes Events plugin configuration documentation with new parameters for database journal mode, locking behavior, and DNS settings.
  • Clarified plugin behavior regarding event collection without fixed intervals.
  • Reorganized configuration documentation for improved readability.

✏️ Tip: You can customize this high-level summary in your review settings.

- Add missing config parameters: db.journal_mode, db.locking,
  dns_retries, dns_wait_time
- Fix tls.verify default from 'On' to 'true' to match source
- Fix kube_namespace default from 'all' to none
- Sort parameters alphabetically
- Align table format with other input plugin docs
- Expand tls.debug description with all debug levels

Fixes fluent#2272.

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell self-assigned this Dec 2, 2025
@eschabell eschabell requested review from a team as code owners December 2, 2025 19:23
@eschabell eschabell added the 4.2 label Dec 2, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 2, 2025

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between bca4af1 and 4480d9d.

📒 Files selected for processing (1)
  • pipeline/inputs/kubernetes-events.md (2 hunks)
 ____________________
< I dream in semver. >
 --------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Walkthrough

The Kubernetes events input plugin documentation was updated to include five previously undocumented configuration parameters (db.sync, db.journal_mode, db.locking, dns_retries, dns_wait_time). The configuration section was restructured into a clearer table format with expanded defaults and descriptions.

Changes

Cohort / File(s) Summary
Documentation Update
pipeline/inputs/kubernetes-events.md
Expanded configuration parameters table to include missing database and DNS settings; reformatted configuration section and updated descriptive text regarding event collection behavior

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that all five missing configuration parameters (db.sync, db.journal_mode, db.locking, dns_retries, dns_wait_time) are correctly documented
  • Cross-reference parameter descriptions and defaults against the actual implementation
  • Confirm that the updated prose accurately reflects the plugin's event collection behavior

Poem

🐰 Five lost parameters, now found and bright,
Documented clearly in tables of light,
The kubernetes events, no longer in dark,
Configuration complete—mission arc!
Hop hop, docs restored!

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: adding missing parameters and fixing defaults in the kubernetes-events documentation.
Linked Issues check ✅ Passed The PR addresses all five missing parameters from #2272 (db.sync, db.journal_mode, db.locking, dns_retries, dns_wait_time) and includes additional documentation improvements like fixing defaults and expanding descriptions.
Out of Scope Changes check ✅ Passed All changes are directly related to the linked issue: adding missing parameters, fixing incorrect defaults (tls.verify, kube_namespace), and improving documentation alignment—no out-of-scope modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell
Copy link
Collaborator Author

AI review passed but waiting on code PR to be merged here as configuration parameters don't exist until then: fluent/fluent-bit#11244

@eschabell
Copy link
Collaborator Author

Based on changes requested in the code PR, adjusting docs PR here to match.

… match code PR.

Signed-off-by: Eric D. Schabell <eric@schabell.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kubernetes events input plugin missing config parameters in doc.

2 participants