docs(azure_blob): add managed identity and workload identity auth#2381
docs(azure_blob): add managed identity and workload identity auth#2381temporaer wants to merge 1 commit intofluent:masterfrom
Conversation
📝 WalkthroughWalkthroughDocumentation for Azure Blob output expanded to include authentication options (managed identity, workload identity) with configuration examples, new properties (client_id, tenant_id, workload_identity_token_file), and guidance for AKS and Azurite scenarios. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Document new auth_type values (managed_identity, workload_identity) and related configuration parameters (client_id, tenant_id, workload_identity_token_file) with configuration examples. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Hannes Schulz <Hannes.Schulz@microsoft.com>
bfff2ab to
1a1d28c
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pipeline/outputs/azure_blob.md (1)
235-296: Workload Identity section is well-documented.The Workload Identity configuration is properly explained with:
- Clear context about AKS and federated service accounts
- Complete examples showing all required parameters (
client_id,tenant_id)- Helpful note about overriding the token file path for non-standard configurations
The examples correctly demonstrate the workload identity authentication pattern for AKS environments.
Optional enhancement: Consider briefly mentioning that workload identity requires proper AKS cluster setup and service account federation (perhaps with a link to Azure documentation), though this may be beyond the scope of Fluent Bit-specific documentation.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pipeline/outputs/azure_blob.md` around lines 235 - 296, Add a brief one-sentence note under the Workload Identity section (near the fluent-bit.yaml / fluent-bit.conf examples) stating that AKS must have service account federation configured for workload identity to work and include a short link to the Azure AD workload identity docs (for example, Azure docs on Workload Identity Federation) so readers can follow cluster setup steps; reference the examples and the workload_identity_token_file, client_id and tenant_id options so the note appears adjacent to those configuration snippets.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pipeline/outputs/azure_blob.md`:
- Around line 235-296: Add a brief one-sentence note under the Workload Identity
section (near the fluent-bit.yaml / fluent-bit.conf examples) stating that AKS
must have service account federation configured for workload identity to work
and include a short link to the Azure AD workload identity docs (for example,
Azure docs on Workload Identity Federation) so readers can follow cluster setup
steps; reference the examples and the workload_identity_token_file, client_id
and tenant_id options so the note appears adjacent to those configuration
snippets.
|
@temporaer thanks for the PR, but looks like some linting issues need fixing. |
Document new
auth_typevalues (managed_identity,workload_identity) and related configuration parameters (client_id,tenant_id,workload_identity_token_file) for the Azure Blob output plugin, with configuration examples for system-assigned MI, user-assigned MI, and workload identity.Companion to fluent/fluent-bit#10777.
Summary by CodeRabbit