docs: outputs: cloudwatch: add workers, fix classic key casing, fix bool values#2420
Conversation
…ool values - Add missing workers parameter with correct default of 1 - Apply Title_Case to all [OUTPUT] keys across all 5 classic config examples - Fix auto_create_group boolean: true -> On in classic config metrics examples - Align [INPUT] and [FILTER] key spacing in classic config examples for consistency Applies to fluent#2412 Signed-off-by: Eric D. Schabell <eric@schabell.org>
📝 WalkthroughWalkthroughThis PR updates the CloudWatch output configuration documentation by adding a workers parameter to the configuration table and converting configuration keys from snake_case to CamelCase format, with alignment adjustments for consistency. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pipeline/outputs/cloudwatch.md (1)
91-91: Update allowed boolean values text to match examples.Examples now use
Auto_create_group On, but the parameter table still says allowed values are onlytrue,false. Please includeon/offthere to avoid contradictory guidance.Suggested doc patch
-| `auto_create_group` | Automatically create the log group. Allowed values: `true`, `false` (case insensitive). | `false` | +| `auto_create_group` | Automatically create the log group. Allowed values: `true`, `false`, `on`, `off` (case insensitive). | `false` |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pipeline/outputs/cloudwatch.md` at line 91, The parameter documentation for Auto_create_group is inconsistent with examples: update the parameter table entry for Auto_create_group to list allowed boolean values as both true/false and on/off (matching examples like "Auto_create_group On"), and note that values are case-insensitive if applicable; locate references to "Auto_create_group" in the docs and add "on/off" alongside "true/false" in the allowed values cell and any descriptive text.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pipeline/outputs/cloudwatch.md`:
- Line 91: The parameter documentation for Auto_create_group is inconsistent
with examples: update the parameter table entry for Auto_create_group to list
allowed boolean values as both true/false and on/off (matching examples like
"Auto_create_group On"), and note that values are case-insensitive if
applicable; locate references to "Auto_create_group" in the docs and add
"on/off" alongside "true/false" in the allowed values cell and any descriptive
text.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 57158c09-c7db-4be2-995f-984941d84d95
📒 Files selected for processing (1)
pipeline/outputs/cloudwatch.md
|
@cosmo0920 and @patrick-stephens ready for review! |
Applies to #2412
Summary by CodeRabbit