docs: outputs: s3: document format parameter for OTLP JSON output#2570
Conversation
- add a `format` configuration parameter documenting `json_lines`
(default) and `otlp_json` values, and noting that `log_key` isn't
supported when `format` is `otlp_json`
Note this is a fix for code changes without corresponding docs PR
Signed-off-by: Eric D. Schabell <eric@schabell.org>
📝 WalkthroughWalkthroughThis PR adds a documentation entry for the ChangesS3 Output Format Parameter Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pipeline/outputs/s3.md (1)
54-54: ⚡ Quick winConsider adding an example configuration demonstrating OTLP JSON format usage.
Since this introduces a new format option for OTLP JSON output, adding an example configuration section would help users understand how to use this feature, especially given the constraint that
log_keyis not supported in this mode.📋 Example configuration suggestion
You could add a new example section (perhaps after the "Get started" section or within it) demonstrating OTLP JSON format usage:
# Example: Using OTLP JSON format pipeline: outputs: - name: s3 match: '*' bucket: your-bucket region: us-east-1 format: otlp_json store_dir: /home/ec2-user/buffer total_file_size: 50M upload_timeout: 10m🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pipeline/outputs/s3.md` at line 54, Add a short example configuration showing how to use the new otlp_json format for the S3 output: include the outputs block with name: s3, match, bucket, region, format: otlp_json, and relevant required fields such as store_dir, total_file_size, and upload_timeout, and mention that log_key is not supported when format is otlp_json; reference the existing `format`, `otlp_json`, `log_key`, and `outputs` symbols so the example is placed near the S3 output docs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pipeline/outputs/s3.md`:
- Line 54: Update the `format` table entry to explicitly state the runtime
behavior when `format` is set to `otlp_json`: mention that only `logs` event
chunks are converted to OTLP JSON and that non-logs event chunks (e.g.,
`metrics`, `traces`) are not converted and are dropped/ignored (or, if your
implementation emits a warning or error, state that instead); also keep the note
that `log_key` is not supported with `otlp_json` and add a short recommendation
to emit a warning or surface an error if non-logs chunks are received so users
aren’t surprised.
---
Nitpick comments:
In `@pipeline/outputs/s3.md`:
- Line 54: Add a short example configuration showing how to use the new
otlp_json format for the S3 output: include the outputs block with name: s3,
match, bucket, region, format: otlp_json, and relevant required fields such as
store_dir, total_file_size, and upload_timeout, and mention that log_key is not
supported when format is otlp_json; reference the existing `format`,
`otlp_json`, `log_key`, and `outputs` symbols so the example is placed near the
S3 output docs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
formatconfiguration parameter documentingjson_lines(default) andotlp_jsonvalues, and noting thatlog_keyisn't supported whenformatisotlp_jsonNote this is a fix for code changes without corresponding docs PR
Summary by CodeRabbit
formatconfiguration parameter for Amazon S3 output, including supported values (json_lines,otlp_json), default settings, and related constraints.