github: workflows: remove trivy cron workflow#11599
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can validate your CodeRabbit configuration file in your editor.If your editor has YAML language server, you can enable auto-completion and validation by adding |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4eefa48df9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| schedule: | ||
| # 13:44 on Thursday | ||
| - cron: 44 13 * * 4 | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Restore a scheduled scan for released
latest images
Removing this trigger drops the only workflow that periodically rescans fluent/fluent-bit:latest. The remaining Trivy job in .github/workflows/call-build-images.yaml:287-315 only runs as part of image builds (if: inputs.push), while .github/workflows/staging-release.yaml:538-579 later promotes latest tags to DockerHub without any follow-up scan. In practice, CVEs disclosed after a release—the common case for base-image/package vulnerabilities—will no longer be reported for the published latest images until the next rebuild, leaving release containers unmonitored for days or weeks.
Useful? React with 👍 / 👎.
| - name: Pull the image for the architecture we're testing | ||
| run: | | ||
| docker pull --platform ${{ matrix.arch }} fluent/fluent-bit:latest |
There was a problem hiding this comment.
Keep per-architecture Trivy scans for ARM release images
This deletion also removes the only place that scanned the published ARM variants individually. The fallback scan in .github/workflows/call-build-images.yaml:306-314 invokes Trivy once against the multi-arch tag on ubuntu-latest and does not pass --platform; Trivy's own image docs note that, by default, it loads the linux/amd64 image unless --platform is set. After removing this matrix, linux/arm64 and linux/arm/v7 release images no longer get vulnerability coverage, so ARM-only CVEs can ship unnoticed.
Useful? React with 👍 / 👎.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.