Skip to content

github: workflows: remove trivy cron workflow#11599

Merged
edsiper merged 1 commit into4.2from
4.2-remove-trivy
Mar 21, 2026
Merged

github: workflows: remove trivy cron workflow#11599
edsiper merged 1 commit into4.2from
4.2-remove-trivy

Conversation

@edsiper
Copy link
Copy Markdown
Member

@edsiper edsiper commented Mar 21, 2026


Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 21, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8365a3a8-b511-454d-a91d-82f2c4ba57aa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 4.2-remove-trivy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can validate your CodeRabbit configuration file in your editor.

If your editor has YAML language server, you can enable auto-completion and validation by adding # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json at the top of your CodeRabbit configuration file.

@edsiper edsiper merged commit 00e2f56 into 4.2 Mar 21, 2026
10 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4eefa48df9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines -10 to -13
schedule:
# 13:44 on Thursday
- cron: 44 13 * * 4
workflow_dispatch:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore a scheduled scan for released latest images

Removing this trigger drops the only workflow that periodically rescans fluent/fluent-bit:latest. The remaining Trivy job in .github/workflows/call-build-images.yaml:287-315 only runs as part of image builds (if: inputs.push), while .github/workflows/staging-release.yaml:538-579 later promotes latest tags to DockerHub without any follow-up scan. In practice, CVEs disclosed after a release—the common case for base-image/package vulnerabilities—will no longer be reported for the published latest images until the next rebuild, leaving release containers unmonitored for days or weeks.

Useful? React with 👍 / 👎.

Comment on lines -45 to -47
- name: Pull the image for the architecture we're testing
run: |
docker pull --platform ${{ matrix.arch }} fluent/fluent-bit:latest
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep per-architecture Trivy scans for ARM release images

This deletion also removes the only place that scanned the published ARM variants individually. The fallback scan in .github/workflows/call-build-images.yaml:306-314 invokes Trivy once against the multi-arch tag on ubuntu-latest and does not pass --platform; Trivy's own image docs note that, by default, it loads the linux/amd64 image unless --platform is set. After removing this matrix, linux/arm64 and linux/arm/v7 release images no longer get vulnerability coverage, so ARM-only CVEs can ship unnoticed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant