tests: integration: introduce in-tree integration test suite#11663
Merged
tests: integration: introduce in-tree integration test suite#11663
Conversation
Introduce Fluent Bit’s in-tree integration test suite as a dedicated end-to-end test harness for plugin and protocol validation. Document that it comes from the original github.com/fluent/fluent-bit-test-suite project and is now shipped inside Fluent Bit as the integration test suite, while excluding local runtime artifacts from version control. Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
|
Important Review skippedToo many files! This PR contains 186 files, which is 36 over the limit of 150. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (186)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86dec2e1c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert service.read_message(0) == "before" | ||
|
|
||
| service.replace_config() | ||
| service.flb.wait_for_hot_reload_count(1) |
There was a problem hiding this comment.
The hot-reload scenario invokes wait_for_hot_reload_count, send_sighup, and trigger_http_reload, but the FluentBitManager added in this commit (tests/integration/src/utils/fluent_bit_manager.py) does not define any of these methods. Because run_tests.py defaults to running all scenarios, this causes the hot-reload tests to fail with AttributeError as soon as this line is reached, so the new integration suite cannot complete successfully.
Useful? React with 👍 / 👎.
| import requests | ||
|
|
||
| from src.utils import fluent_bit_manager as manager_module | ||
| from src.utils.fluent_bit_manager import ENV_FLB_BINARY_PATH |
There was a problem hiding this comment.
This test module imports ENV_FLB_BINARY_PATH and later exercises send_signal/hot-reload helpers that are not present in the committed src/utils/fluent_bit_manager.py, so running pytest tests/test_fluent_bit_manager.py fails at import/attribute resolution instead of executing assertions. As written, the file provides no usable coverage and will break targeted test runs for this component.
Useful? React with 👍 / 👎.
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
edsiper
requested review from
celalettin1286,
niedbalski and
patrick-stephens
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce Fluent Bit’s in-tree integration test suite as a dedicated end-to-end test harness for plugin and protocol validation. Document that it comes from the original github.com/fluent/fluent-bit-test-suite project and is now shipped inside Fluent Bit as the integration test suite, while excluding local runtime artifacts from version control.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.