tests: http_client_chunked: Plug SEGV occurence on macOS#11711
tests: http_client_chunked: Plug SEGV occurence on macOS#11711
Conversation
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
📝 WalkthroughWalkthroughA test file for HTTP client chunking adds coroutine support initialization. A file-local guard ensures Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/runtime/http_client_chunked.c`:
- Around line 172-175: The if-statement that initializes coroutines uses an
opening brace on the same line; update the formatting to place the opening brace
on the next line to follow the project C style for control blocks: locate the
check using coro_initialized and the call flb_coro_init() and reformat the if
(coro_initialized == FLB_FALSE) to put the brace on the next line while keeping
the existing body and logic unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6fa31279-781d-4018-9b25-7fe92cbb928b
📒 Files selected for processing (1)
tests/runtime/http_client_chunked.c
http_client_chunked test case is always failing on macOS due to uninitialized conroutine on the test case.
We need to ensure initializing coroutine before running the actual assertions.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit
No user-facing changes in this update.