routing: fix issue with missing input alias [Backport to 4.2]#11864
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e87660883c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cfl_list_init(&input->routes); | ||
| input->has_alias = FLB_FALSE; | ||
| input->instance = NULL; | ||
| input->instance = find_input_instance_by_index(config, input_index); |
There was a problem hiding this comment.
When a config file is loaded into a flb_ctx_t that already has inputs added through the public API (flb_input() appends to config->inputs, and flb_lib_config_file() then loads sections into the same config), this pre-binds the first file input’s routes to input index 0 in the whole config, not index 0 among inputs created from that file. For an aliased input section, the previous alias lookup would still find the file-created instance, but now find_input_instance() returns this preselected instance immediately, so routes from the config section can be applied to an unrelated earlier programmatic input.
Useful? React with 👍 / 👎.
2 participants
Backporting of #11717 except for integration testing commit:
f5dd9f8
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.