-
Notifications
You must be signed in to change notification settings - Fork 1.9k
out_es: Add experimental support for Amazon ElasticSearch for 1.4 #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
AWS credentials must be specified with environment variables, but it works (by 1.5, we'll have full support for all credentials providers). Config: Output: |
|
I also built Fluent Bit with |
b761ce2 to
12f8d0f
Compare
|
Doc PR: fluent/fluent-bit-docs#260 |
|
thanks for this. Would you please split the commits per components ? in two like :
|
806856b to
2917d52
Compare
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
2917d52 to
967af85
Compare
|
@edsiper updated |
|
thanks! |
Thanks a lot for the work @edsiper ! Once you support credentials provider could you include the Web identity provider? It's supported by all the latest AWS SDK versions, and is the go to solution, for a secure IAM/EKS role mapping. https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-technical-overview.html |
We will. I'm working on a full set of providers including EKS:
Agreed. The Fluent Bit docs for this feature note that it's experimental and that it might not be suitable for production workloads. I probably won't enable this feature in AWS for Fluent Bit either; instead we'll wait for the full set of providers to be completed. |
|
@PettitWesley Thanks! it looks like it's all coming. It seems much better than using proxy for the IAM signing. I'll follow all of this closely. Let us know if we can helm with testing |
@jujugrrr You can for sure; that would be awesome. The ECR image link noted below should be accessible from any AWS account. It includes all of the credential providers except for EC2 instance role. I'd be especially interested to know if you're an app mesh user- that's one test case I haven't covered yet- making sure the envoy proxy does not affect any of the calls Fluent Bit makes. (We've had some issues in the past where on startup calls will fail- though that was in ECS).
|
|
No app-mesh here, probably Istio in the future though. I tried
#1852, but when merging your
branch to fluent-bit master we were getting conflicts and some build issues
during the docker build.
Does the ECS image include the ENV changes only or all your other providers?
…On Thu, 13 Feb 2020 at 21:54, Wesley Pettit ***@***.***> wrote:
Let us know if we can help with testing
@jujugrrr <https://github.com/jujugrrr> You can for sure; that would be
awesome. The ECR image link noted below should be accessible from any AWS
account. It includes all of the credential provider except for EC2 instance
role.
I'd be especially interested to know if you're an app mesh user- that's
one test case I haven't covered yet- making sure the envoy proxy does not
affect any of the calls Fluent Bit makes. (We've had some issues in the
past where on startup calls will fail- though that was in ECS).
-
714124127858.dkr.ecr.us-west-2.amazonaws.com/fluent-bit-elastic-search-bug-bash:latest
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1920?email_source=notifications&email_token=AA6ICL2EI22U4KQ32TKDBKLRCW6RRA5CNFSM4KM5TZP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELWYDBQ#issuecomment-585990534>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6ICLZABFBMWD4MMK2FYLDRCW6RRANCNFSM4KM5TZPQ>
.
|
Yup, as I noted, it has all of the credential providers besides EC2 instance role. |
Addresses #1804 and #1807