Unittest cleanup #17
Merged
Unittest cleanup #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is already the perfectly fine `python ./setup.py test` or `python ./setup.py nosetest` if nose is installed and tox. The run_tests script is based on tests module importing all submodules but this currently fails as it seems some files were not added to the VCS in commit "implement UDS (Unix Domain Socket) sender" commit.
Recent tox.ini as predefined definitions for most python interpreters so just remove them. Also, py32 and py33 are not available on current OSX release so enabling the skip_missing_interpreter looks like a good idea for development purpose.
Not really a regression since previous code has this problem with unicode but comes from "Simplify check for string in record formating" commit.
Enable coverage and add relevant files to print a nice report.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of minor changes that should result in running unittests on all supported python interpreters.
It also enables unittest coverage report and integration to coveralls.io for tracking and badges in the README.md. Don't forget to change the URLs when merging to those of the organization so that it reflects your master and not mine :-).
This superseeds merge request #12 I guess as well.