Skip to content

feat: add storage.path support to tail and systemd input plugins#1901

Merged
wenchajun merged 2 commits intofluent:masterfrom
majiayu000:fix/issue-1693-add-storage-path-to-tail-and-systemd
Apr 16, 2026
Merged

feat: add storage.path support to tail and systemd input plugins#1901
wenchajun merged 2 commits intofluent:masterfrom
majiayu000:fix/issue-1693-add-storage-path-to-tail-and-systemd

Conversation

@majiayu000
Copy link
Copy Markdown
Contributor

Fixes #1693

Changes

Add StoragePath string field to both Tail and Systemd input plugin structs, following the existing pattern for StorageType. Updated Params() methods to serialize storage.path when set. Regenerated DeepCopy methods and CRD manifests via make generate manifests.

Test Plan

  • Added unit tests for both Tail and Systemd Params() methods verifying storage.path appears in output when StoragePath is set
  • Verified storage.path is omitted when StoragePath is empty
  • make test passes

@majiayu000 majiayu000 marked this pull request as ready for review March 17, 2026 07:25
@marcofranssen marcofranssen force-pushed the fix/issue-1693-add-storage-path-to-tail-and-systemd branch 2 times, most recently from 77c2711 to a0090c7 Compare April 1, 2026 18:16
wenchajun
wenchajun previously approved these changes Apr 14, 2026
@wenchajun
Copy link
Copy Markdown
Member

@copilot resolve the merge conflicts in this pull request

Add StoragePath field to Tail and Systemd input plugin structs to allow
specifying a filesystem location for buffered data storage. Without this
field, users cannot configure storage.path in the fluentbit config.

Fixes fluent#1693

Signed-off-by: majiayu000 <1835304752@qq.com>
@majiayu000 majiayu000 force-pushed the fix/issue-1693-add-storage-path-to-tail-and-systemd branch from a0090c7 to f3d7491 Compare April 14, 2026 13:04
Signed-off-by: majiayu000 <1835304752@qq.com>
@majiayu000
Copy link
Copy Markdown
Contributor Author

Rebased on master and regenerated the missing CRD under charts/fluent-operator/crds/. CI should be green now.

@wenchajun wenchajun enabled auto-merge (squash) April 16, 2026 08:06
@wenchajun wenchajun disabled auto-merge April 16, 2026 08:06
@wenchajun wenchajun enabled auto-merge (squash) April 16, 2026 08:07
@wenchajun wenchajun merged commit ff0fee9 into fluent:master Apr 16, 2026
13 checks passed
@wenchajun
Copy link
Copy Markdown
Member

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: can't specify storage.path in the fluentbit config

2 participants