feat: add logical_op support to grep filter#1903
Merged
cw-Guo merged 3 commits intoMar 21, 2026
Merged
Conversation
Add LogicalOp field to the Grep filter CRD spec to allow configuring the logical operation for multiple regex/exclude rules. Fluent Bit supports this natively via the Logical_Op parameter. Closes fluent#1316 Signed-off-by: majiayu000 <1835304752@qq.com>
Include generated CRD schema changes for the logicalOp enum field in Helm chart templates, CRD bases, and setup manifests. Add test coverage for LogicalOp "or" value and empty-string omit case. Update doc to list valid enum values. Signed-off-by: majiayu000 <1835304752@qq.com>
Collaborator
|
Hi @majiayu000 can you fix the docs difference? you can run |
Signed-off-by: majiayu000 <1835304752@qq.com>
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1316
Changes
LogicalOpfield to the Grep filter struct with+kubebuilder:validation:Enum:=and;orvalidationParams()method to renderLogical_Opin the generated Fluent Bit configLogical_Opappears correctly in rendered configTest Plan
clusterfilter_types_test.gowith Regex, Exclude, and LogicalOp fields setmake testpassesmake manifestsregenerates CRDs with the newlogicalOpenum field