feat(fluentbit): Support more settings for firehose output#1954
Open
smallc2009 wants to merge 1 commit into
Open
feat(fluentbit): Support more settings for firehose output#1954smallc2009 wants to merge 1 commit into
smallc2009 wants to merge 1 commit into
Conversation
Signed-off-by: Anson <anson.liu@live.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends Fluent Bit’s Firehose output plugin CRD/API surface in fluent-operator, exposing additional Firehose configuration knobs (compression, external credentials/profile, aggregation, and worker threads) and propagating them through generated CRDs, Helm chart CRDs, and plugin documentation.
Changes:
- Added
compression,externalID,profile,simpleAggregation, andworkersfields to the Firehose output API and render them into Fluent Bit plugin params. - Regenerated/updated CRDs and Helm chart CRD artifacts to include schema + validation (notably enum validation for
compression). - Added a unit test to validate Firehose parameter rendering for the newly supported fields.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| manifests/setup/setup.yaml | Updated generated installation manifest CRD schema to include the new Firehose fields. |
| manifests/setup/fluent-operator-crd.yaml | Updated generated CRD bundle with the new Firehose fields. |
| docs/plugins/fluentbit/output/firehose.md | Documented the newly supported Firehose output options. |
| config/crd/bases/fluentbit.fluent.io_outputs.yaml | Updated base Output CRD schema with new Firehose fields and validation. |
| config/crd/bases/fluentbit.fluent.io_clusteroutputs.yaml | Updated base ClusterOutput CRD schema with new Firehose fields and validation. |
| charts/fluent-operator/crds/fluentbit.fluent.io_outputs.yaml | Updated Helm-packaged Output CRD with new Firehose fields. |
| charts/fluent-operator/crds/fluentbit.fluent.io_clusteroutputs.yaml | Updated Helm-packaged ClusterOutput CRD with new Firehose fields. |
| charts/fluent-operator-fluent-bit-crds/templates/fluentbit.fluent.io_outputs.yaml | Updated Fluent Bit CRD chart template (Output) with new Firehose fields. |
| charts/fluent-operator-fluent-bit-crds/templates/fluentbit.fluent.io_clusteroutputs.yaml | Updated Fluent Bit CRD chart template (ClusterOutput) with new Firehose fields. |
| apis/fluentbit/v1alpha2/plugins/output/zz_generated.deepcopy.go | Regenerated deepcopy methods to include new Firehose fields. |
| apis/fluentbit/v1alpha2/plugins/output/firehose_types.go | Added new Firehose fields + rendered them into plugin parameters. |
| apis/fluentbit/v1alpha2/plugins/output/firehose_types_test.go | Added unit test coverage for new Firehose parameter rendering. |
Files not reviewed (1)
- apis/fluentbit/v1alpha2/plugins/output/zz_generated.deepcopy.go: Language not supported
e2983ef to
6bffebd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request adds several new configuration options to the Firehose output plugin in Fluent Bit, enhancing its flexibility and AWS integration. The changes include support for data compression, external AWS credentials, aggregation, and worker configuration. Corresponding updates are made to the CRDs, Helm charts. Unit tests are also added to ensure correct parameter handling.
Firehose Output Plugin Enhancements:
Firehosestruct:Compression,ExternalID,Profile,SimpleAggregation, andWorkersto allow configuration of data compression, external AWS credentials, aggregation, and worker threads.CRD and Helm Chart Updates:
fluentbit.fluent.io_outputs.yaml,fluentbit.fluent.io_clusteroutputs.yaml) to document and validate the new Firehose plugin options, including allowed values for compression and types for all new fields.Testing Improvements:
firehose_types_test.go) to verify that all new parameters are correctly set and passed to the plugin.Which issue(s) this PR fixes:
Fixes #1875
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: