feat(fluentbit): add retainMetadataInForwardMode to forward output pl…#1973
Open
joshuabaird wants to merge 8 commits into
Open
feat(fluentbit): add retainMetadataInForwardMode to forward output pl…#1973joshuabaird wants to merge 8 commits into
joshuabaird wants to merge 8 commits into
Conversation
joshuabaird
force-pushed
the
chore/fluentbit/retain-metadata-in-forward
branch
2 times, most recently
from
4500874 to
a6c78e0
Compare
…ugin Adds the RetainMetadataInForwardMode field to the Fluent Bit forward output plugin CRD type. Since Fluent Bit v5.0.5 changed the default of retain_metadata_in_forward_mode to true, forwarding to Fluentd breaks with "skip invalid event" errors. Setting this field to false restores Fluentd compatibility. Fixes fluent#1972. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Josh Baird <jbaird@galileo.io>
Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Josh Baird <jbaird@galileo.io>
Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Josh Baird <jbaird@galileo.io>
Adds fluentd.forward.retainMetadataInForwardMode to values.yaml (null by default, so existing installs are unaffected) and renders it in the fluentbit-output-forward ClusterOutput template when set. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Josh Baird <jbaird@galileo.io>
joshuabaird
force-pushed
the
chore/fluentbit/retain-metadata-in-forward
branch
from
a6c78e0 to
b62b0d3
Compare
Signed-off-by: Josh Baird <jbaird@galileo.io> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Josh Baird <jbaird@galileo.io> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for Fluent Bit forward output option retain_metadata_in_forward_mode to address Fluent Bit v5.0.5+ interoperability issues with Fluentd (Fixes #1972) by exposing it through the CRD API, Helm chart values, and generated manifests.
Changes:
- Extend Fluent Bit
Forwardoutput plugin API withretainMetadataInForwardModeand render it into output params. - Regenerate CRDs/manifests to include the new field in Output/ClusterOutput schemas.
- Document and wire the option through the Helm chart (
values.yaml+ template).
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| manifests/setup/setup.yaml | Regenerated install manifest CRDs to include retainMetadataInForwardMode in forward output schema. |
| manifests/setup/fluent-operator-crd.yaml | Regenerated aggregated CRD bundle with the new forward output field. |
| docs/plugins/fluentbit/output/forward.md | Documents the new retainMetadataInForwardMode field for the forward output plugin. |
| config/crd/bases/fluentbit.fluent.io_outputs.yaml | Regenerated base Output CRD schema to add the new boolean field. |
| config/crd/bases/fluentbit.fluent.io_clusteroutputs.yaml | Regenerated base ClusterOutput CRD schema to add the new boolean field. |
| charts/fluent-operator/values.yaml | Adds Helm value fluentd.forward.retainMetadataInForwardMode (nullable by default). |
| charts/fluent-operator/templates/fluentbit-output-forward.yaml | Conditionally renders retainMetadataInForwardMode into the generated ClusterOutput. |
| charts/fluent-operator/crds/fluentbit.fluent.io_outputs.yaml | Updates chart-packaged Output CRD with the new field. |
| charts/fluent-operator/crds/fluentbit.fluent.io_clusteroutputs.yaml | Updates chart-packaged ClusterOutput CRD with the new field. |
| charts/fluent-operator-fluent-bit-crds/templates/fluentbit.fluent.io_outputs.yaml | Updates fluent-bit CRDs subchart Output schema with the new field. |
| charts/fluent-operator-fluent-bit-crds/templates/fluentbit.fluent.io_clusteroutputs.yaml | Updates fluent-bit CRDs subchart ClusterOutput schema with the new field. |
| apis/fluentbit/v1alpha2/plugins/output/zz_generated.deepcopy.go | Regenerated deepcopy logic to include the new pointer field. |
| apis/fluentbit/v1alpha2/plugins/output/forward_types.go | Adds RetainMetadataInForwardMode to the Forward output plugin and renders it into params. |
Files not reviewed (1)
- apis/fluentbit/v1alpha2/plugins/output/zz_generated.deepcopy.go: Language not supported
Signed-off-by: Josh Baird <jbaird@galileo.io> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
retainMetadataInForwardModeto fluentbit forward output.Fixes #1972.