rpm: fix update error if working directory is missing by Watson1978 · Pull Request #955 · fluent/fluent-package-builder

Watson1978 · 2026-02-10T05:59:45Z

If /tmp/fluent/ was removed, it causes error when update to Fluent Package 6.0.x as following:

# dnf install ./fluent-package-5.0.9-1.el8.x86_64.rpm

# rm -rf /tmp/fluent/

# dnf install -y ./fluent-package-6.0.1-1.el8.x86_64.rpm
Last metadata expiration check: 0:55:01 ago on Tue Feb 10 05:05:41 2026.
Dependencies resolved.
====================================================================================================================================================================
 Package                                   Architecture                      Version                                  Repository                               Size
====================================================================================================================================================================
Upgrading:
 fluent-package                            x86_64                            6.0.1-1.el8                              @commandline                             23 M

Transaction Summary
====================================================================================================================================================================
Upgrade  1 Package

Total size: 23 M
Downloading Packages:
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                                                                            1/1
  Running scriptlet: fluent-package-6.0.1-1.el8.x86_64                                                                                                          1/1
  Running scriptlet: fluent-package-6.0.1-1.el8.x86_64                                                                                                          1/2
/var/tmp/rpm-tmp.Fp7H9o: line 39: /tmp/fluent/.local_base_plugins: No such file or directory
error: %prein(fluent-package-6.0.1-1.el8.x86_64) scriptlet failed, exit status 1

Error in PREIN scriptlet in rpm package fluent-package
  Verifying        : fluent-package-6.0.1-1.el8.x86_64                                                                                                          1/2
  Verifying        : fluent-package-5.0.9-1.el8.x86_64                                                                                                          2/2

Failed:
  fluent-package-5.0.9-1.el8.x86_64                                                fluent-package-6.0.1-1.el8.x86_64

Error: Transaction failed

kenhys

I come to think using /tmp/fluent is bad design failure.

So, it might be better to switch using /var/cache/fluent or something instead.
What do you think?
(If already /var/cache/fluent is used by user, need to care that too)

Watson1978 · 2026-02-12T04:29:27Z

That makes sense.
it might be appropriate into /var/cache/fluent.

In additional, maybe we should replace /tmp/fluent/.main_pid into /var/run/fluent.main_pid or other.

Watson1978 · 2026-02-12T05:14:59Z

In additional, maybe we should replace /tmp/fluent/.main_pid into /var/run/fluent.main_pid or other.

I did miss read.
main pid files already located in /var/run/fluent/fluentd.pid

# systemctl cat fluentd
# /usr/lib/systemd/system/fluentd.service
...

PIDFile=/var/run/fluent/fluentd.pid

...

kenhys

Could you add test case for downgrading to v6.0.0 or v6.0.1?
something like downgrade-to-v6-lts-tmpfiles.sh

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

- Switch from /tmp/fluent to /var/cache/fluent for upgrade-related files. - This avoids issues where /tmp is cleaned by systemd-tmpfiles or accidentally modified by users. - Ensures the directory exists during the package upgrade process. Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

> Job 'test' depends on job 'confluent_test' which creates a cycle in the dependency graph., Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys · 2026-02-24T01:40:12Z

Added nitpick fix which was introduced by #972 accidentally.

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

kenhys

LGTM.

Watson1978 · 2026-02-24T05:09:48Z

Thanks

@commandline

If `/tmp/fluent/` was removed, it causes error when update to Fluent Package 6.0.x as following: ``` # dnf install ./fluent-package-5.0.9-1.el8.x86_64.rpm # rm -rf /tmp/fluent/ # dnf install -y ./fluent-package-6.0.1-1.el8.x86_64.rpm Last metadata expiration check: 0:55:01 ago on Tue Feb 10 05:05:41 2026. Dependencies resolved. ==================================================================================================================================================================== Package Architecture Version Repository Size ==================================================================================================================================================================== Upgrading: fluent-package x86_64 6.0.1-1.el8 @commandline 23 M Transaction Summary ==================================================================================================================================================================== Upgrade 1 Package Total size: 23 M Downloading Packages: Running transaction check Transaction check succeeded. Running transaction test Transaction test succeeded. Running transaction Preparing : 1/1 Running scriptlet: fluent-package-6.0.1-1.el8.x86_64 1/1 Running scriptlet: fluent-package-6.0.1-1.el8.x86_64 1/2 /var/tmp/rpm-tmp.Fp7H9o: line 39: /tmp/fluent/.local_base_plugins: No such file or directory error: %prein(fluent-package-6.0.1-1.el8.x86_64) scriptlet failed, exit status 1 Error in PREIN scriptlet in rpm package fluent-package Verifying : fluent-package-6.0.1-1.el8.x86_64 1/2 Verifying : fluent-package-5.0.9-1.el8.x86_64 2/2 Failed: fluent-package-5.0.9-1.el8.x86_64 fluent-package-6.0.1-1.el8.x86_64 Error: Transaction failed ``` --------- Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com> Co-authored-by: Kentaro Hayashi <hayashi@clear-code.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

@commandline

…955) (#977) Backport #955 If `/tmp/fluent/` was removed, it causes error when update to Fluent Package 6.0.x as following: ``` # dnf install ./fluent-package-5.0.9-1.el8.x86_64.rpm # rm -rf /tmp/fluent/ # dnf install -y ./fluent-package-6.0.1-1.el8.x86_64.rpm Last metadata expiration check: 0:55:01 ago on Tue Feb 10 05:05:41 2026. Dependencies resolved. ==================================================================================================================================================================== Package Architecture Version Repository Size ==================================================================================================================================================================== Upgrading: fluent-package x86_64 6.0.1-1.el8 @commandline 23 M Transaction Summary ==================================================================================================================================================================== Upgrade 1 Package Total size: 23 M Downloading Packages: Running transaction check Transaction check succeeded. Running transaction test Transaction test succeeded. Running transaction Preparing : 1/1 Running scriptlet: fluent-package-6.0.1-1.el8.x86_64 1/1 Running scriptlet: fluent-package-6.0.1-1.el8.x86_64 1/2 /var/tmp/rpm-tmp.Fp7H9o: line 39: /tmp/fluent/.local_base_plugins: No such file or directory error: %prein(fluent-package-6.0.1-1.el8.x86_64) scriptlet failed, exit status 1 Error in PREIN scriptlet in rpm package fluent-package Verifying : fluent-package-6.0.1-1.el8.x86_64 1/2 Verifying : fluent-package-5.0.9-1.el8.x86_64 2/2 Failed: fluent-package-5.0.9-1.el8.x86_64 fluent-package-6.0.1-1.el8.x86_64 Error: Transaction failed ``` --------- Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com> Co-authored-by: Kentaro Hayashi <hayashi@clear-code.com>

Watson1978 changed the title ~~Fix update error when working directory is missing~~ rpm: fix update error when working directory is missing Feb 10, 2026

Watson1978 changed the title ~~rpm: fix update error when working directory is missing~~ rpm: fix update error if working directory is missing Feb 10, 2026

Watson1978 force-pushed the working-directory branch 6 times, most recently from ca11a50 to db58633 Compare February 10, 2026 08:41

Watson1978 marked this pull request as ready for review February 12, 2026 00:52

Watson1978 force-pushed the working-directory branch from db58633 to 49a74ea Compare February 12, 2026 00:53

Watson1978 requested a review from kenhys February 12, 2026 00:55

kenhys reviewed Feb 12, 2026

View reviewed changes

Watson1978 added this to the v6.1.0 milestone Feb 12, 2026

Watson1978 added the backport to v6.0 Need to be backported LTS label Feb 12, 2026

Watson1978 force-pushed the working-directory branch from 1e6d6e9 to c942015 Compare February 13, 2026 01:01

Watson1978 marked this pull request as draft February 13, 2026 01:11

Watson1978 force-pushed the working-directory branch 12 times, most recently from 6786caf to b4214a6 Compare February 17, 2026 08:00

Watson1978 force-pushed the working-directory branch from 7e55233 to 501a445 Compare February 19, 2026 01:19

Watson1978 marked this pull request as ready for review February 19, 2026 03:18

Watson1978 requested a review from kenhys February 19, 2026 03:18

kenhys requested changes Feb 19, 2026

View reviewed changes

Watson1978 force-pushed the working-directory branch from ec73fdb to 100fbe1 Compare February 20, 2026 07:01

Watson1978 and others added 11 commits February 24, 2026 10:36

rpm: fix update error if working directory is missing

1205af1

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

Update test case

6f90ef4

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

Remove /var/cache/fluent when uninstall the package

86e7b35

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

Ensure to remove tmp files for auto restart

2ab3f6c

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

Add gaurd

37116c5

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

Ensure to create working directory for downgrading

ad5f92d

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

Move temporary directory creation to appropriate function

b33173e

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

Fix comment style

6ff9658

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

Add downgrade tests

f1519f4

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

ci: fix circular job dependency

bf13c43

> Job 'test' depends on job 'confluent_test' which creates a cycle in the dependency graph., Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys force-pushed the working-directory branch from 100fbe1 to bf13c43 Compare February 24, 2026 01:38

kenhys reviewed Feb 24, 2026

View reviewed changes

Comment thread fluent-package/apt/systemd-test/downgrade-to-v6-lts-tmpfiles.sh Outdated

kenhys requested changes Feb 24, 2026

View reviewed changes

Fix local package file path to install

89d8116

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

Watson1978 requested a review from kenhys February 24, 2026 04:52

kenhys approved these changes Feb 24, 2026

View reviewed changes

Watson1978 merged commit b5c1ce3 into fluent:master Feb 24, 2026
431 of 435 checks passed

Watson1978 deleted the working-directory branch February 24, 2026 05:15

Watson1978 mentioned this pull request Feb 24, 2026

Backport(v6): rpm: fix update error if working directory is missing (#955) #977

Merged

Watson1978 added the backported Already backported to LTS branch (e.g. fluent-package-v5) label Feb 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rpm: fix update error if working directory is missing#955

rpm: fix update error if working directory is missing#955
Watson1978 merged 12 commits intofluent:masterfrom
Watson1978:working-directory

Watson1978 commented Feb 10, 2026 •

edited

Loading

Uh oh!

kenhys left a comment

Uh oh!

Watson1978 commented Feb 12, 2026

Uh oh!

Watson1978 commented Feb 12, 2026

Uh oh!

kenhys left a comment

Uh oh!

kenhys commented Feb 24, 2026

Uh oh!

Uh oh!

kenhys left a comment

Uh oh!

Watson1978 commented Feb 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Watson1978 commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kenhys left a comment

Choose a reason for hiding this comment

Uh oh!

Watson1978 commented Feb 12, 2026

Uh oh!

Watson1978 commented Feb 12, 2026

Uh oh!

kenhys left a comment

Choose a reason for hiding this comment

Uh oh!

kenhys commented Feb 24, 2026

Uh oh!

Uh oh!

kenhys left a comment

Choose a reason for hiding this comment

Uh oh!

Watson1978 commented Feb 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Watson1978 commented Feb 10, 2026 •

edited

Loading