Skip to content

Conversation

@brsolomon-deloitte
Copy link
Contributor

Add some flags to curl to raise error on failed request and ensure
output is stdout. Use bash rather than text blocks.

Add some flags to curl to raise error on failed request and ensure
output is stdout. Use bash rather than text blocks.

Signed-off-by: Brad Solomon <81818815+brsolomon-deloitte@users.noreply.github.com>
@kenhys
Copy link
Contributor

kenhys commented Oct 7, 2021

It seems to use -fsSL is better, but is -o- really needed? (I'm not sure)

@brsolomon-deloitte
Copy link
Contributor Author

Yes, I suppose it is redundant in this case. From man curl

Specifying the output as '-' (a single dash) will force the output to be done to stdout.

But that would really only be useful if multiple -o are passed, now that I think about it.

Signed-off-by: Brad Solomon <81818815+brsolomon-deloitte@users.noreply.github.com>
@brsolomon-deloitte
Copy link
Contributor Author

It seems to use -fsSL is better, but is -o- really needed? (I'm not sure)

Removed in b2c2f06.

@kenhys kenhys merged commit f8a4088 into fluent:1.0 Oct 8, 2021
@kenhys
Copy link
Contributor

kenhys commented Oct 8, 2021

@brsolomon-deloitte

Thanks!

@brsolomon-deloitte brsolomon-deloitte deleted the curl-fssl branch October 8, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants